Bug 1533071 - Enable OpenH264 plugin for win64-aarch64; r=jya a=RyanVM
authorDan Minor <dminor@mozilla.com>
Tue, 09 Apr 2019 14:46:05 +0000
changeset 523277 2e258ddb1483f5993821845a8713fe7b0aac5c7a
parent 523276 00567ac38963b491628cc9d70e131ffd4f67b029
child 523278 9b8ad8b840ed4cc8545123c49a2cafb401e322d3
push id11125
push usernbeleuzu@mozilla.com
push dateMon, 22 Apr 2019 16:37:45 +0000
treeherdermozilla-beta@ceb8833f34c3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya, RyanVM
bugs1533071
milestone67.0
Bug 1533071 - Enable OpenH264 plugin for win64-aarch64; r=jya a=RyanVM This enables the OpenH264 plugin for win64-aarch64. It also disables hardware decoding of OpenH264 on that platform due to Windows crashes when decoding OpenH264 streams. Differential Revision: https://phabricator.services.mozilla.com/D24917
browser/app/profile/firefox.js
modules/libpref/init/all.js
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -1488,25 +1488,19 @@ pref("media.gmp.trial-create.enabled", t
 // to enable the CDM if its disabled; it's as if the keysystem is completely
 // unsupported.
 
 #ifdef MOZ_WIDEVINE_EME
 pref("media.gmp-widevinecdm.visible", true);
 pref("media.gmp-widevinecdm.enabled", true);
 #endif
 
-#if defined(_ARM64_) && defined(XP_WIN)
-// Windows on ARM64, OpenH264 not available yet.
-pref("media.gmp-gmpopenh264.visible", false);
-pref("media.gmp-gmpopenh264.enabled", false);
-#else
-// Not Windows on ARM64
 pref("media.gmp-gmpopenh264.visible", true);
 pref("media.gmp-gmpopenh264.enabled", true);
-#endif
+
 // Switch block autoplay logic to v2, and enable UI.
 pref("media.autoplay.enabled.user-gestures-needed", true);
 // Set Firefox to block autoplay, asking for permission by default.
 pref("media.autoplay.default", 1); // 0=Allowed, 1=Blocked
 
 #ifdef NIGHTLY_BUILD
 // Block WebAudio from playing automatically.
 pref("media.autoplay.block-webaudio", true);
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -461,16 +461,18 @@ pref("media.navigator.video.h264.max_br"
 pref("media.navigator.video.h264.max_mbps", 0);
 #if defined(NIGHTLY_BUILD) && !defined(ANDROID)
 pref("media.navigator.mediadatadecoder_vpx_enabled", true);
 #else
 pref("media.navigator.mediadatadecoder_vpx_enabled", false);
 #endif
 #if defined(ANDROID)
 pref("media.navigator.mediadatadecoder_h264_enabled", false); // bug 1509316
+#elif defined(_ARM64_) && defined(XP_WIN)
+pref("media.navigator.mediadatadecoder_h264_enabled", false);
 #else
 pref("media.navigator.mediadatadecoder_h264_enabled", true);
 #endif
 pref("media.peerconnection.video.vp9_enabled", true);
 pref("media.peerconnection.video.vp9_preferred", false);
 pref("media.getusermedia.browser.enabled", false);
 pref("media.getusermedia.channels", 0);
 #if defined(ANDROID)