Bug 1531400 - Missing bottom border on netmonitor table's header; r=ladybenko
authorJan Odvarko <odvarko@gmail.com>
Thu, 14 Mar 2019 16:49:04 +0000
changeset 521912 2d742819b35b1b462b20614e583ec8dce773c946
parent 521911 9071e6d7836b7647c4698745b4e7fe67c4e40300
child 521913 88f1641459184352c5bf333ef12aa7ac4c3a28e4
push id10870
push usernbeleuzu@mozilla.com
push dateFri, 15 Mar 2019 20:00:07 +0000
treeherdermozilla-beta@c594aee5b7a4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersladybenko
bugs1531400
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1531400 - Missing bottom border on netmonitor table's header; r=ladybenko Differential Revision: https://phabricator.services.mozilla.com/D22959
devtools/client/netmonitor/test/browser_net_autoscroll.js
devtools/client/themes/toolbars.css
--- a/devtools/client/netmonitor/test/browser_net_autoscroll.js
+++ b/devtools/client/netmonitor/test/browser_net_autoscroll.js
@@ -49,17 +49,18 @@ add_task(async function() {
 
   // (4) Now select the first item in the list
   // and check that additional requests do not change the scroll position
   // from just below the headers.
   store.dispatch(Actions.selectRequestByIndex(0));
   await waitForNetworkEvents(monitor, 8);
   await waitSomeTime();
   const requestsContainerHeaders = document.querySelector(".requests-list-headers");
-  const headersHeight = requestsContainerHeaders.offsetHeight;
+  const headersHeight =
+    Math.floor(requestsContainerHeaders.getBoundingClientRect().height);
   is(requestsContainer.scrollTop, headersHeight, "Did not scroll.");
 
   // Stop doing requests.
   await ContentTask.spawn(tab.linkedBrowser, {}, function() {
     content.wrappedJSObject.stopRequests();
   });
 
   // Done: clean up.
--- a/devtools/client/themes/toolbars.css
+++ b/devtools/client/themes/toolbars.css
@@ -29,16 +29,21 @@
   line-height: 24px;
   box-sizing: border-box;
 }
 
 .devtools-toolbar {
   padding: 0 3px;
 }
 
+/* <thead> nor <tr> support border, we have to style the <td> */
+.devtools-toolbar td {
+  border-bottom: 1px solid var(--theme-splitter-color);
+}
+
 .devtools-toolbar-bottom {
   border-top-width: 1px;
   border-bottom: none;
 }
 
 /* Expected space around a separator:
  * -----------------------
  *            4