Bug 1371525 - Warn when sending a synchronous RemoteLogins:findRecipes message. r=Felipe
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Fri, 01 Sep 2017 14:59:55 -0700
changeset 427966 2d4783c5bf18027bd687213ad26f3f5160da606e
parent 427965 8040b9fc23d782ad2cf0ff3beda30d99faf75010
child 427967 59db725def8282e1d77e83f002d247c7d0f95237
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersFelipe
bugs1371525
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1371525 - Warn when sending a synchronous RemoteLogins:findRecipes message. r=Felipe MozReview-Commit-ID: F3JnVQlFNT0
toolkit/components/passwordmgr/LoginRecipes.jsm
--- a/toolkit/components/passwordmgr/LoginRecipes.jsm
+++ b/toolkit/components/passwordmgr/LoginRecipes.jsm
@@ -199,16 +199,17 @@ var LoginRecipesContent = {
   /**
    * Locally caches recipes for a given host.
    *
    * @param {String} aHost (e.g. example.com:8080 [non-default port] or sub.example.com)
    * @param {Object} win - the window of the host
    * @param {Set} recipes - recipes that apply to the host
    */
   cacheRecipes(aHost, win, recipes) {
+    log.debug("cacheRecipes: for:", aHost);
     let recipeMap = this._recipeCache.get(win);
 
     if (!recipeMap) {
       recipeMap = new Map();
       this._recipeCache.set(win, recipeMap);
     }
 
     recipeMap.set(aHost, recipes);
@@ -235,16 +236,17 @@ var LoginRecipesContent = {
     }
 
     let mm = win.QueryInterface(Ci.nsIInterfaceRequestor)
                 .getInterface(Ci.nsIWebNavigation)
                 .QueryInterface(Ci.nsIDocShell)
                 .QueryInterface(Ci.nsIInterfaceRequestor)
                 .getInterface(Ci.nsIContentFrameMessageManager);
 
+    log.warn("getRecipes: falling back to a synchronous message for:", aHost);
     recipes = mm.sendSyncMessage("RemoteLogins:findRecipes", { formOrigin: aHost })[0];
     this.cacheRecipes(aHost, win, recipes);
 
     return recipes;
   },
 
   /**
    * @param {Set} aRecipes - Possible recipes that could apply to the form