bug 1523104: remote: drop outdated todos; r=me
authorAndreas Tolfsen <ato@sny.no>
Thu, 07 Mar 2019 22:16:04 +0000
changeset 521135 2c703d235c4c
parent 521134 e94205832ec1
child 521136 2dd67c30b7ae
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1523104
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1523104: remote: drop outdated todos; r=me
remote/Connection.jsm
--- a/remote/Connection.jsm
+++ b/remote/Connection.jsm
@@ -20,36 +20,31 @@ class Connection {
     this.transport.hooks = this;
     this.onmessage = () => {};
 
     this.transport.ready();
   }
 
   send(message) {
     log.trace(`<-(connection ${this.id}) ${JSON.stringify(message)}`);
-    // TODO(ato): Check return types
     this.transport.send(message);
   }
 
   error(id, e) {
     const error = {
       message: e.message,
       data: e.stack,
     };
     this.send({id, error});
   }
 
   deserialize(data) {
     const id = data.id;
     const method = data.method;
-    // TODO(ato): what if params is falsy?
     const params = data.params || {};
-
-    // TODO(ato): Do protocol validation (Protocol.jsm)
-
     return {id, method, params};
   }
 
   // transport hooks
 
   onPacket(packet) {
     log.trace(`(connection ${this.id})-> ${JSON.stringify(packet)}`);