Bug 1132950 - Don't keep showing sort arrow on a column if another column is selected. r=jaws
authorTim Nguyen <ntim.bugs@gmail.com>
Sat, 14 Feb 2015 10:41:00 +0100
changeset 256168 2c5db2a83e340bb23907437d60cbb891ad0e1350
parent 256167 4d43899972e7574b7632010b622c6f9e17cd3e5a
child 256169 93f2c43f45e0834858e236140512dabca3bb92b0
push id4610
push userjlund@mozilla.com
push dateMon, 30 Mar 2015 18:32:55 +0000
treeherdermozilla-beta@4df54044d9ef [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1132950
milestone38.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1132950 - Don't keep showing sort arrow on a column if another column is selected. r=jaws
toolkit/components/viewconfig/content/config.js
--- a/toolkit/components/viewconfig/content/config.js
+++ b/toolkit/components/viewconfig/content/config.js
@@ -90,17 +90,17 @@ var view = {
         index = gPrefView.length - index - 1;
     }
     else {
       var pref = null;
       if (index >= 0)
         pref = gPrefView[index];
 
       var old = document.getElementById(gSortedColumn);
-      old.setAttribute("sortDirection", "");
+      old.removeAttribute("sortDirection");
       gPrefArray.sort(gSortFunction = gSortFunctions[col.id]);
       if (gPrefView != gPrefArray)
         gPrefView.sort(gSortFunction);
       gSortedColumn = col.id;
       if (pref)
         index = getViewIndexOfPref(pref);
     }
     col.element.setAttribute("sortDirection", gSortDirection > 0 ? "ascending" : "descending");