Bug 1067552 - Assertion in RuntimeService::ShutdownIdleThreads. r=bent
☠☠ backed out by 71054ae20547 ☠ ☠
authorGregor Wagner <anygregor@gmail.com>
Mon, 15 Sep 2014 22:09:10 +0200
changeset 228690 2a7cae8b0b5d5056c53a27f979a8e62fc7852c13
parent 228689 01fe5d23d233f3215998d188e089d1f30a52294c
child 228691 0a53e55db53d0bf339c4298f6603328fbe739056
push id4187
push userbhearsum@mozilla.com
push dateFri, 28 Nov 2014 15:29:12 +0000
treeherdermozilla-beta@f23cc6a30c11 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbent
bugs1067552
milestone35.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1067552 - Assertion in RuntimeService::ShutdownIdleThreads. r=bent
dom/workers/RuntimeService.cpp
--- a/dom/workers/RuntimeService.cpp
+++ b/dom/workers/RuntimeService.cpp
@@ -1686,17 +1686,17 @@ RuntimeService::ShutdownIdleThreads(nsIT
       thread->swap(info.mThread);
     }
 
     if (!expiredThreads.IsEmpty()) {
       runtime->mIdleThreadArray.RemoveElementsAt(0, expiredThreads.Length());
     }
   }
 
-  NS_ASSERTION(nextExpiration.IsNull() || !expiredThreads.IsEmpty(),
+  NS_ASSERTION(!nextExpiration.IsNull() || !expiredThreads.IsEmpty(),
                "Should have a new time or there should be some threads to shut "
                "down");
 
   for (uint32_t index = 0; index < expiredThreads.Length(); index++) {
     if (NS_FAILED(expiredThreads[index]->Shutdown())) {
       NS_WARNING("Failed to shutdown thread!");
     }
   }