Fix some bad variable names, no bug
authorEhsan Akhgari <ehsan@mozilla.com>
Tue, 04 Aug 2015 19:10:51 -0400
changeset 287906 2a0e43caef9b8edbf03fc20d1a220c63f0164f5d
parent 287905 dd7436fa536c40d4fdbfb7cdad414d6a00c7a549
child 287907 65f68419dbfcefe79421876936e62c7b0a58a9df
push id5067
push userraliiev@mozilla.com
push dateMon, 21 Sep 2015 14:04:52 +0000
treeherdermozilla-beta@14221ffe5b2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Fix some bad variable names, no bug
build/clang-plugin/tests/TestGlobalClass.cpp
--- a/build/clang-plugin/tests/TestGlobalClass.cpp
+++ b/build/clang-plugin/tests/TestGlobalClass.cpp
@@ -12,27 +12,27 @@ struct MOZ_GLOBAL_CLASS TemplateClass {
   T i;
 };
 
 void gobble(void *) { }
 
 void misuseGlobalClass(int len) {
   Global notValid; // expected-error {{variable of type 'Global' only valid as global}}
   Global alsoNotValid[2]; // expected-error {{variable of type 'Global [2]' only valid as global}} expected-note {{'Global [2]' is a global type because it is an array of global type 'Global'}}
-  static Global valid; // expected-error {{variable of type 'Global' only valid as global}}
-  static Global alsoValid[2]; // expected-error {{variable of type 'Global [2]' only valid as global}} expected-note {{'Global [2]' is a global type because it is an array of global type 'Global'}}
+  static Global notValid2; // expected-error {{variable of type 'Global' only valid as global}}
+  static Global alsoNotValid2[2]; // expected-error {{variable of type 'Global [2]' only valid as global}} expected-note {{'Global [2]' is a global type because it is an array of global type 'Global'}}
 
-  gobble(&valid);
+  gobble(&notValid2);
   gobble(&notValid);
-  gobble(&alsoValid[0]);
+  gobble(&alsoNotValid2[0]);
 
   gobble(new Global); // expected-error {{variable of type 'Global' only valid as global}}
   gobble(new Global[10]); // expected-error {{variable of type 'Global' only valid as global}}
   gobble(new TemplateClass<int>); // expected-error {{variable of type 'TemplateClass<int>' only valid as global}}
-  gobble(len <= 5 ? &valid : new Global); // expected-error {{variable of type 'Global' only valid as global}}
+  gobble(len <= 5 ? &notValid2 : new Global); // expected-error {{variable of type 'Global' only valid as global}}
 
   char buffer[sizeof(Global)];
   gobble(new (buffer) Global); // expected-error {{variable of type 'Global' only valid as global}}
 }
 
 Global valid;
 struct RandomClass {
   Global nonstaticMember; // expected-note {{'RandomClass' is a global type because member 'nonstaticMember' is a global type 'Global'}}