author | Ali Akhtarzada <ali@comoyo.com> |
Fri, 24 Jan 2014 08:42:12 -0500 | |
changeset 181079 | 2a0c73990f05ee54bc4db91a7e6f8942148c4c90 |
parent 181078 | 04a456bcbf297674bb9b30bbd4280c53f42f7427 |
child 181080 | fdc031b9b0830b16365a490457b1e1cb9ff80308 |
push id | 3343 |
push user | ffxbld |
push date | Mon, 17 Mar 2014 21:55:32 +0000 |
treeherder | mozilla-beta@2f7d3415f79f [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | mattwoodrow |
bugs | 962288, 959123 |
milestone | 29.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/gfx/layers/ImageContainer.h +++ b/gfx/layers/ImageContainer.h @@ -955,18 +955,16 @@ public: nsRefPtr<gfxASurface> surface = mDeprecatedSurface.get(); return surface.forget(); } gfx::IntSize GetSize() { return mSize; } CairoImage() : Image(nullptr, CAIRO_SURFACE) {} -private: - nsCountedRef<nsMainThreadSurfaceRef> mDeprecatedSurface; gfx::IntSize mSize; // mSourceSurface wraps mDeprrecatedSurface's data, therefore it should not // outlive mDeprecatedSurface nsCountedRef<nsMainThreadSourceSurfaceRef> mSourceSurface; };
--- a/gfx/layers/d3d10/ImageLayerD3D10.cpp +++ b/gfx/layers/d3d10/ImageLayerD3D10.cpp @@ -208,24 +208,24 @@ ImageLayerD3D10::RenderLayer() } IntSize size = image->GetSize(); SetEffectTransformAndOpacity(); ID3D10EffectTechnique *technique; nsRefPtr<IDXGIKeyedMutex> keyedMutex; - nsRefPtr<gfxASurface> surf = image->DeprecatedGetAsSurface(); if (image->GetFormat() == ImageFormat::CAIRO_SURFACE || image->GetFormat() == ImageFormat::REMOTE_IMAGE_BITMAP || image->GetFormat() == ImageFormat::REMOTE_IMAGE_DXGI_TEXTURE || image->GetFormat() == ImageFormat::D3D9_RGB32_TEXTURE) { NS_ASSERTION(image->GetFormat() != ImageFormat::CAIRO_SURFACE || - !surf || surf->GetContentType() != gfxContentType::ALPHA, + !static_cast<CairoImage*>(image)->mDeprecatedSurface || + static_cast<CairoImage*>(image)->mDeprecatedSurface->GetContentType() != gfxContentType::ALPHA, "Image layer has alpha image"); bool hasAlpha = false; nsRefPtr<ID3D10ShaderResourceView> srView = GetImageSRView(image, hasAlpha, getter_AddRefs(keyedMutex)); if (!srView) { return; }
--- a/gfx/layers/d3d9/ImageLayerD3D9.cpp +++ b/gfx/layers/d3d9/ImageLayerD3D9.cpp @@ -409,19 +409,19 @@ ImageLayerD3D9::RenderLayer() SetShaderTransformAndOpacity(); gfx::IntSize size = image->GetSize(); if (image->GetFormat() == CAIRO_SURFACE || image->GetFormat() == REMOTE_IMAGE_BITMAP || image->GetFormat() == D3D9_RGB32_TEXTURE) { - nsRefPtr<gfxASurface> surf = image->DeprecatedGetAsSurface(); NS_ASSERTION(image->GetFormat() != CAIRO_SURFACE || - !surf || surf->GetContentType() != gfxContentType::ALPHA, + !static_cast<CairoImage*>(image)->mDeprecatedSurface || + static_cast<CairoImage*>(image)->mDeprecatedSurface->GetContentType() != gfxContentType::ALPHA, "Image layer has alpha image"); bool hasAlpha = false; nsRefPtr<IDirect3DTexture9> texture = GetTexture(image, hasAlpha); device()->SetVertexShaderConstantF(CBvLayerQuad, ShaderConstantRect(0, 0,