Bug 1507644 - Remove dubious test in widget/gtk/moz.build. r=chmanchester
authorMike Hommey <mh+mozilla@glandium.org>
Fri, 16 Nov 2018 21:19:51 +0000
changeset 503286 29ffc266326bffc33dfe8ba03b5c748627f65040
parent 503285 b006cee2f7bd408d6185828a31546545b21721de
child 503287 01a4f2502443cc27d2092a4b46427d062f55a1ec
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerschmanchester
bugs1507644
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1507644 - Remove dubious test in widget/gtk/moz.build. r=chmanchester The intent of the test is to barf at configure time when the target system doesn't use the glibc. The reason behind this is that the setup with the mozwayland stub library relies on the dynamic linking order the glibc uses. However, the test checks GLIB_LIBS, which is the result of pkg-config --libs for *GLIB*, not glibc, and all Gtk builds use glib, irrespective of the libc in use. Practically speaking, this means the error branch can't ever be taken... except on artifact builds, because we don't run pkg-config tests there. The dynamic linking order problem only really matter when wayland is enabled at runtime, which it isn't by default. We'll eventually have to sort it out for tier 3 platforms, but the current moz.build doesn't do anything for them anyways. Differential Revision: https://phabricator.services.mozilla.com/D12074
widget/gtk/moz.build
--- a/widget/gtk/moz.build
+++ b/widget/gtk/moz.build
@@ -12,20 +12,17 @@ with Files("*CompositorWidget*"):
 
 with Files("*WindowSurface*"):
     BUG_COMPONENT = ("Core", "Graphics")
 
 if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gtk3':
     DIRS += ['mozgtk']
 
 if CONFIG['MOZ_WAYLAND']:
-    if CONFIG['GLIB_LIBS']:
-        DIRS += ['wayland', 'mozwayland']
-    else:
-        error('We support Wayland on glibc systems only, see Bug 1409707 for reference.')
+    DIRS += ['wayland', 'mozwayland']
 
 EXPORTS += [
     'mozcontainer.h',
     'nsGTKToolkit.h',
     'nsIImageToPixbuf.h',
 ]
 
 EXPORTS.mozilla += [