Bug 1535005 - part1 : no need to update 'mLastTimeMarchesOnCalled' in 'DidSeek()' r=jya
authorAlastor Wu <alwu@mozilla.com>
Wed, 01 May 2019 23:16:42 +0000
changeset 531017 2885da69f0f3b60a9d500e4b9212f219b3476cdc
parent 531016 be38681e82877a61527772e5831ccd6399aec61d
child 531018 f188012d248d72153c9a5068b38ba247dac4deb9
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya
bugs1535005
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1535005 - part1 : no need to update 'mLastTimeMarchesOnCalled' in 'DidSeek()' r=jya According to spec [1], `mLastTimeMarchesOnCalled` is used to represent the `last time` in step3. It's used to record last time we run `TimeMarchOn()`, so there is no need to upate it on `DidSeek()`. [1] https://html.spec.whatwg.org/multipage/media.html#time-marches-on Differential Revision: https://phabricator.services.mozilla.com/D29094
dom/html/TextTrackManager.cpp
--- a/dom/html/TextTrackManager.cpp
+++ b/dom/html/TextTrackManager.cpp
@@ -227,22 +227,16 @@ void TextTrackManager::RemoveTextTrack(T
       mNewCues->RemoveCue(*((*removeCueList)[i]));
     }
     TimeMarchesOn();
   }
 }
 
 void TextTrackManager::DidSeek() {
   WEBVTT_LOG("DidSeek");
-  if (mMediaElement) {
-    mLastTimeMarchesOnCalled =
-        media::TimeUnit::FromSeconds(mMediaElement->CurrentTime());
-    WEBVTT_LOGV("DidSeek set mLastTimeMarchesOnCalled %lf",
-                mLastTimeMarchesOnCalled.ToSeconds());
-  }
   mHasSeeked = true;
 }
 
 void TextTrackManager::UpdateCueDisplay() {
   WEBVTT_LOG("UpdateCueDisplay");
   mUpdateCueDisplayDispatched = false;
 
   if (!mMediaElement || !mTextTracks || IsShutdown()) {