Bug 1483122 - "https" is pushed off left edge of address bar (overlapping buttons!) for long URLs with broken cert configurations r=Gijs
authorDrew Willcoxon <adw@mozilla.com>
Wed, 22 Aug 2018 22:29:52 +0000
changeset 488041 265d09efe73f674a364194d4ad16dfd77d0aab57
parent 488040 d57a6d415507fb7e43cad18c2755aa124b84bbbe
child 488042 cc2cb08f3759f4c0250c081c5696d13c5a86725a
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1483122, 1470910, 1480355
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1483122 - "https" is pushed off left edge of address bar (overlapping buttons!) for long URLs with broken cert configurations r=Gijs Bug 1470910 broke the positioning because it changed the tag name of .urlbar-input-box but didn't update the related rule in browser.css, and then bug 1480355 landed and made it worse. This patch fixes the first problem by updating the tag name in the CSS, and it fixes the second problem (and bug 1480355) by setting `direction: ltr` on .urlbar-input-box. Differential Revision: https://phabricator.services.mozilla.com/D4015
browser/base/content/browser.css
--- a/browser/base/content/browser.css
+++ b/browser/base/content/browser.css
@@ -574,23 +574,23 @@ html|input.urlbar-input[dir=ltr]:-moz-lo
   background-color: rgba(255,170,68,.8);
   color: black;
 }
 #main-window[remotecontrol] #urlbar #identity-box {
   background: white;
 }
 
 /* Show the url scheme in a static box when overflowing to the left */
-hbox.urlbar-input-box {
+moz-input-box.urlbar-input-box {
   position: relative;
+  direction: ltr;
 }
 html|input.urlbar-scheme {
   position: absolute;
   height: 100%;
-  left: 0;
   visibility: hidden;
   direction: ltr;
   pointer-events: none;
 }
 
 /* Visible if the urlbar is not focused and it overflows at the start.
    Uses the required-valid trick to check if it contains a value */
 html|input.urlbar-scheme[textoverflow="start"]:not([focused]):valid {