Bug 1639733 - video playhead telemetry r=thecount
authorGavin Lazar Suntop <gavin@gsuntop.com>
Thu, 28 May 2020 15:21:20 +0000
changeset 596608 264bbddd5c2773b0cb405683fbfe2767c55b81d4
parent 596607 1eb4ed3edfedf78bd689d1fdf9cda2ed591bdec7
child 596609 3d70dea460923ca9f0ab6975f68328bb5f2ddd13
push id13186
push userffxbld-merge
push dateMon, 01 Jun 2020 09:52:46 +0000
treeherdermozilla-beta@3e7c70a1e4a1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersthecount
bugs1639733
milestone78.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1639733 - video playhead telemetry r=thecount Differential Revision: https://phabricator.services.mozilla.com/D76357
browser/components/newtab/content-src/components/DiscoveryStreamComponents/DSCard/DSCard.jsx
browser/components/newtab/data/content/activity-stream.bundle.js
--- a/browser/components/newtab/content-src/components/DiscoveryStreamComponents/DSCard/DSCard.jsx
+++ b/browser/components/newtab/content-src/components/DiscoveryStreamComponents/DSCard/DSCard.jsx
@@ -139,25 +139,29 @@ export class _DSCard extends React.PureC
     ];
   }
 
   onLinkClick(event) {
     if (this.props.dispatch) {
       this.props.dispatch(
         ac.UserEvent({
           event: "CLICK",
-          source: this.props.type.toUpperCase(),
+          source: this.props.is_video
+            ? "CARDGRID_VIDEO"
+            : this.props.type.toUpperCase(),
           action_position: this.props.pos,
           value: { card_type: this.props.flightId ? "spoc" : "organic" },
         })
       );
 
       this.props.dispatch(
         ac.ImpressionStats({
-          source: this.props.type.toUpperCase(),
+          source: this.props.is_video
+            ? "CARDGRID_VIDEO"
+            : this.props.type.toUpperCase(),
           click: 0,
           tiles: [
             {
               id: this.props.id,
               pos: this.props.pos,
               ...(this.props.shim && this.props.shim.click
                 ? { shim: this.props.shim.click }
                 : {}),
@@ -281,17 +285,17 @@ export class _DSCard extends React.PureC
                 id: this.props.id,
                 pos: this.props.pos,
                 ...(this.props.shim && this.props.shim.impression
                   ? { shim: this.props.shim.impression }
                   : {}),
               },
             ]}
             dispatch={this.props.dispatch}
-            source={this.props.type}
+            source={this.props.is_video ? "CARDGRID_VIDEO" : this.props.type}
           />
         </SafeAnchor>
         <DSLinkMenu
           id={this.props.id}
           index={this.props.pos}
           dispatch={this.props.dispatch}
           url={this.props.url}
           title={this.props.title}
--- a/browser/components/newtab/data/content/activity-stream.bundle.js
+++ b/browser/components/newtab/data/content/activity-stream.bundle.js
@@ -4804,24 +4804,24 @@ class _DSCard extends react__WEBPACK_IMP
       height: 101
     }];
   }
 
   onLinkClick(event) {
     if (this.props.dispatch) {
       this.props.dispatch(common_Actions_jsm__WEBPACK_IMPORTED_MODULE_0__["actionCreators"].UserEvent({
         event: "CLICK",
-        source: this.props.type.toUpperCase(),
+        source: this.props.is_video ? "CARDGRID_VIDEO" : this.props.type.toUpperCase(),
         action_position: this.props.pos,
         value: {
           card_type: this.props.flightId ? "spoc" : "organic"
         }
       }));
       this.props.dispatch(common_Actions_jsm__WEBPACK_IMPORTED_MODULE_0__["actionCreators"].ImpressionStats({
-        source: this.props.type.toUpperCase(),
+        source: this.props.is_video ? "CARDGRID_VIDEO" : this.props.type.toUpperCase(),
         click: 0,
         tiles: [{
           id: this.props.id,
           pos: this.props.pos,
           ...(this.props.shim && this.props.shim.click ? {
             shim: this.props.shim.click
           } : {})
         }]
@@ -4932,17 +4932,17 @@ class _DSCard extends react__WEBPACK_IMP
       rows: [{
         id: this.props.id,
         pos: this.props.pos,
         ...(this.props.shim && this.props.shim.impression ? {
           shim: this.props.shim.impression
         } : {})
       }],
       dispatch: this.props.dispatch,
-      source: this.props.type
+      source: this.props.is_video ? "CARDGRID_VIDEO" : this.props.type
     })), react__WEBPACK_IMPORTED_MODULE_4___default.a.createElement(_DSLinkMenu_DSLinkMenu__WEBPACK_IMPORTED_MODULE_2__["DSLinkMenu"], {
       id: this.props.id,
       index: this.props.pos,
       dispatch: this.props.dispatch,
       url: this.props.url,
       title: this.props.title,
       source: this.props.source,
       type: this.props.type,