Bug 1450610 [wpt PR 10264] - Remove test that CSSStyleSheet.media is read-only, a=testonly
authorChris Nardi <cnardi@chromium.org>
Mon, 09 Apr 2018 21:29:46 +0000
changeset 467244 25e91d9ab4e9b9516fbabd0e05bccc3c76f7c0b1
parent 467243 c1715027770e6a4a487ba2ad522b91a6a51691ac
child 467245 97571ebc17d6fb76520bfe0b1bca2b0ff165976c
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1450610, 10264, 821780, 989407, 547451
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1450610 [wpt PR 10264] - Remove test that CSSStyleSheet.media is read-only, a=testonly Automatic update from web-platform-testsRemove test that CSSStyleSheet.media is read-only style-sheet-interfaces-001.html tested that styleSheet.media was read-only, but the spec changed to add a [PutForwards] attribute to |media|, meanining that the attribute is no longer truly read-only. assert_readonly can have side-effects if the property has a [PutForwards] attribute, so remove this check, as it was causing the next test to fail. Bug: 821780 Change-Id: I77bee2f11484f6e679e4aee6b0641179c686d1d3 Reviewed-on: https://chromium-review.googlesource.com/989407 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547451} wpt-commits: af485dcf5f9fb6c1892908ab850b2bf49bc765a2 wpt-pr: 10264 wpt-commits: af485dcf5f9fb6c1892908ab850b2bf49bc765a2 wpt-pr: 10264
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/cssom/style-sheet-interfaces-001.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -534697,17 +534697,17 @@
    "8521d827e1e641c3b856854c38eac66a97ddf690",
    "testharness"
   ],
   "css/cssom/shorthand-serialization.html": [
    "0240668113cb5c280dcb76d8eabfa28d0ed9cb52",
    "testharness"
   ],
   "css/cssom/style-sheet-interfaces-001.html": [
-   "3fbe87bc1e363bf59a84c5fbdd8b2450909c6ca1",
+   "1614c9a0e4973672b18caf46ad56e6cf188285b5",
    "testharness"
   ],
   "css/cssom/style-sheet-interfaces-002.html": [
    "8fc091c20efd7fc71c6c357278977ee6137fd8d4",
    "testharness"
   ],
   "css/cssom/stylesheet-replacedata-dynamic-ref.html": [
    "e733dc40a41b899ab6c184211d75def5e52af3d4",
--- a/testing/web-platform/tests/css/cssom/style-sheet-interfaces-001.html
+++ b/testing/web-platform/tests/css/cssom/style-sheet-interfaces-001.html
@@ -79,20 +79,19 @@
         assert_idl_attribute(styleSheet, "title");
         assert_idl_attribute(styleSheet, "media");
 
         assert_readonly(styleSheet, "type");
         assert_readonly(styleSheet, "ownerNode");
         assert_readonly(styleSheet, "parentStyleSheet");
         assert_readonly(styleSheet, "href");
         assert_readonly(styleSheet, "title");
-        assert_readonly(styleSheet, "media");
     }, "StyleSheet_properties",
     { assert: [ "type, disabled, ownerNode, parentStyleSheet, href, title, and media properties exist on StyleSheet",
-                "type, ownerNode, parentStyleSheet, href, title, media properties are read only" ] });
+                "type, ownerNode, parentStyleSheet, href, and title properties are read only" ] });
 
     test(function() {
         assert_equals(styleSheet.type, "text/css");
         assert_equals(styleSheet.disabled, false);
 
         assert_equals(styleSheet.ownerNode, styleElement);
         assert_equals(linkSheet.ownerNode, linkElement);
         assert_equals(importSheet.ownerNode, null);