Bug 1377216 - Unset MOZ_AUTOMATION when building SpiderMonkey from package; r=glandium
authorGregory Szorc <gps@mozilla.com>
Tue, 18 Jul 2017 17:39:27 -0700
changeset 418765 2582a92759c4f299ed9d7a5b6c99f1ffe13cda99
parent 418764 7b16c219d018fb48f72c64bb7a9c225b23624e15
child 418766 e9dfbaff0283af804bfdef17cf9140be0c06b940
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1377216
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1377216 - Unset MOZ_AUTOMATION when building SpiderMonkey from package; r=glandium We're about to make MOZ_AUTOMATION more strict about things like having a source checkout. The whole point of build-sm-package.sh is to verify that SpiderMonkey can be built outside of Mozilla's source repo and automation from a standalone package. Since the presence of MOZ_AUTOMATION can influence so much behavior in the build system, unset it so that the job tests a !Mozilla environment more accurately. MozReview-Commit-ID: EMfyLKfY0uU
taskcluster/scripts/builder/build-sm-package.sh
--- a/taskcluster/scripts/builder/build-sm-package.sh
+++ b/taskcluster/scripts/builder/build-sm-package.sh
@@ -16,13 +16,18 @@ mkdir -p $PACKAGE_DIR
 pushd $PACKAGE_DIR
 
 tar -xjvf $UPLOAD_DIR/mozjs-*.tar.bz2
 
 : ${PYTHON:=python2.7}
 
 # Build the freshly extracted, packaged SpiderMonkey.
 pushd ./mozjs-*/js/src
+
+# MOZ_AUTOMATION enforces certain requirements that don't apply to
+# packaged builds. Unset it.
+unset MOZ_AUTOMATION
+
 AUTOMATION=1 $PYTHON ./devtools/automation/autospider.py --skip-tests=checks $SPIDERMONKEY_VARIANT
 popd
 
 # Copy artifacts for upload by TaskCluster
 cp -rL ./mozjs-*/obj-spider/dist/bin/{js,jsapi-tests,js-gdb.py,libmozjs*} $UPLOAD_DIR