Backed out 1 changesets (bug 1189554) for suspicion of causing Linux Mn-e10s test failures on a CLOSED TREE
authorCarsten "Tomcat" Book <cbook@mozilla.com>
Thu, 17 Sep 2015 14:40:14 +0200
changeset 295672 24d50ddb2235d8f994b0b2b34edb3c3aaba8a45b
parent 295671 b7a68945a2ac1303d6925a4084c6a29e0f68dc5f
child 295673 655a465bcc04ef292e4c8e5b8cdc75d6b0b5e2bf
push id5245
push userraliiev@mozilla.com
push dateThu, 29 Oct 2015 11:30:51 +0000
treeherdermozilla-beta@dac831dc1bd0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1189554
milestone43.0a1
backs out7f5c883640082a78a94ac293f1800d003df60ca2
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 1 changesets (bug 1189554) for suspicion of causing Linux Mn-e10s test failures on a CLOSED TREE Backed out changeset 7f5c88364008 (bug 1189554)
embedding/components/windowwatcher/nsWindowWatcher.cpp
--- a/embedding/components/windowwatcher/nsWindowWatcher.cpp
+++ b/embedding/components/windowwatcher/nsWindowWatcher.cpp
@@ -1605,17 +1605,17 @@ nsWindowWatcher::CalculateChromeFlags(ns
     if (!PL_strcasestr(aFeatures, "titlebar")) {
       chromeFlags |= nsIWebBrowserChrome::CHROME_TITLEBAR;
     }
     if (!PL_strcasestr(aFeatures, "close")) {
       chromeFlags |= nsIWebBrowserChrome::CHROME_WINDOW_CLOSE;
     }
   }
 
-  if (aDialog && aFeaturesSpecified && !presenceFlag) {
+  if (aDialog && !presenceFlag) {
     chromeFlags = nsIWebBrowserChrome::CHROME_DEFAULT;
   }
 
   /* Finally, once all the above normal chrome has been divined, deal
      with the features that are more operating hints than appearance
      instructions. (Note modality implies dependence.) */
 
   if (WinHasOption(aFeatures, "alwaysLowered", 0, nullptr) ||