Bug 1466043 - Fix intermittency issue and re-enabled browser_extension_update_background_noprompt.js test. r=aswan
authorLuca Greco <lgreco@mozilla.com>
Wed, 16 Jan 2019 23:51:24 +0000
changeset 511421 24982570fc8338ba51f32f142c7d0e6f342cce7d
parent 511420 4ddef07cfb17ed568a321165746546de93259b64
child 511431 1db2248f441513991df17a73112ffd9cc1846846
child 511433 ee03992cef6e9e16a3bb99ab81d3b0468ff85faa
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaswan
bugs1466043
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1466043 - Fix intermittency issue and re-enabled browser_extension_update_background_noprompt.js test. r=aswan Differential Revision: https://phabricator.services.mozilla.com/D16719
browser/base/content/test/webextensions/browser.ini
browser/base/content/test/webextensions/browser_extension_update_background_noprompt.js
--- a/browser/base/content/test/webextensions/browser.ini
+++ b/browser/base/content/test/webextensions/browser.ini
@@ -14,17 +14,16 @@ support-files =
   browser_webext_update_perms2.xpi
   browser_webext_update_origins1.xpi
   browser_webext_update_origins2.xpi
   browser_webext_update.json
 
 [browser_extension_sideloading.js]
 [browser_extension_update_background.js]
 [browser_extension_update_background_noprompt.js]
-skip-if = (verify && debug && (os == 'mac')) || (os == 'win') || (os == 'linux') # Bug 1466043
 [browser_permissions_dismiss.js]
 [browser_permissions_installTrigger.js]
 [browser_permissions_local_file.js]
 [browser_permissions_mozAddonManager.js]
 [browser_permissions_optional.js]
 skip-if = !e10s
 [browser_permissions_pointerevent.js]
 [browser_permissions_unsigned.js]
--- a/browser/base/content/test/webextensions/browser_extension_update_background_noprompt.js
+++ b/browser/base/content/test/webextensions/browser_extension_update_background_noprompt.js
@@ -65,17 +65,17 @@ async function testNoPrompt(origUrl, id)
   is(addons.children.length, 0, "Have 0 updates in the PanelUI menu");
   await gCUITestUtils.hideMainMenu();
 
   ok(!sawPopup, "Should not have seen permissions notification");
 
   addon = await AddonManager.getAddonByID(id);
   is(addon.version, "2.0", "Update should have applied");
 
-  addon.uninstall();
+  await addon.uninstall();
   await SpecialPowers.popPrefEnv();
 }
 
 // Test that an update that adds new non-promptable permissions is just
 // applied without showing a notification dialog.
 add_task(() => testNoPrompt(`${BASE}/browser_webext_update_perms1.xpi`,
                             ID_PERMS));