Bug 1523969 part 7 - Move method definition inline comments to new line in 'extensions/'. r=ehsan
authorRyan Hunt <rhunt@eqrion.net>
Mon, 25 Feb 2019 16:05:47 -0600
changeset 519770 2477669a9f3581da250107db00fa38cc4e4b98a1
parent 519769 f41cee9bf14931b453838d1bbcbda528e3b064e8
child 519771 5b5e6a9942777d6faee07db57fd6b14d465b3ab3
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehsan
bugs1523969
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1523969 part 7 - Move method definition inline comments to new line in 'extensions/'. r=ehsan Differential Revision: https://phabricator.services.mozilla.com/D21107
extensions/auth/nsAuthGSSAPI.cpp
extensions/cookie/nsPermissionManager.cpp
--- a/extensions/auth/nsAuthGSSAPI.cpp
+++ b/extensions/auth/nsAuthGSSAPI.cpp
@@ -309,17 +309,18 @@ void nsAuthGSSAPI::Reset() {
   if (gssLibrary && mCtx != GSS_C_NO_CONTEXT) {
     OM_uint32 minor_status;
     gss_delete_sec_context_ptr(&minor_status, &mCtx, GSS_C_NO_BUFFER);
   }
   mCtx = GSS_C_NO_CONTEXT;
   mComplete = false;
 }
 
-/* static */ void nsAuthGSSAPI::Shutdown() {
+/* static */
+void nsAuthGSSAPI::Shutdown() {
   if (gssLibrary) {
     PR_UnloadLibrary(gssLibrary);
     gssLibrary = nullptr;
   }
 }
 
 /* Limitations apply to this class's thread safety. See the header file */
 NS_IMPL_ISUPPORTS(nsAuthGSSAPI, nsIAuthModule)
--- a/extensions/cookie/nsPermissionManager.cpp
+++ b/extensions/cookie/nsPermissionManager.cpp
@@ -891,17 +891,18 @@ NS_IMETHODIMP DeleteFromMozHostListener:
 
   if (aReason == REASON_ERROR) {
     manager->CloseDB(true);
   }
 
   return NS_OK;
 }
 
-/* static */ void nsPermissionManager::ClearOriginDataObserverInit() {
+/* static */
+void nsPermissionManager::ClearOriginDataObserverInit() {
   nsCOMPtr<nsIObserverService> observerService =
       mozilla::services::GetObserverService();
   observerService->AddObserver(new ClearOriginDataObserver(),
                                "clear-origin-attributes-data",
                                /* ownsWeak= */ false);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -3226,18 +3227,19 @@ nsPermissionManager::SetPermissionsWithK
     uint64_t modificationTime = 0;
     AddInternal(principal, perm.type, perm.capability, 0, perm.expireType,
                 perm.expireTime, modificationTime, eNotify, eNoDBOperation,
                 true /* ignoreSessionPermissions */);
   }
   return NS_OK;
 }
 
-/* static */ void nsPermissionManager::GetKeyForOrigin(
-    const nsACString& aOrigin, nsACString& aKey) {
+/* static */
+void nsPermissionManager::GetKeyForOrigin(const nsACString& aOrigin,
+                                          nsACString& aKey) {
   aKey.Truncate();
 
   // We only key origins for http, https, and ftp URIs. All origins begin with
   // the URL which they apply to, which means that they should begin with their
   // scheme in the case where they are one of these interesting URIs. We don't
   // want to actually parse the URL here however, because this can be called on
   // hot paths.
   if (!StringBeginsWith(aOrigin, NS_LITERAL_CSTRING("http:")) &&
@@ -3281,39 +3283,43 @@ nsPermissionManager::SetPermissionsWithK
 #endif
 
   // Append the stripped suffix to the output origin key.
   nsAutoCString suffix;
   attrs.CreateSuffix(suffix);
   aKey.Append(suffix);
 }
 
-/* static */ void nsPermissionManager::GetKeyForPrincipal(
-    nsIPrincipal* aPrincipal, nsACString& aKey) {
+/* static */
+void nsPermissionManager::GetKeyForPrincipal(nsIPrincipal* aPrincipal,
+                                             nsACString& aKey) {
   nsAutoCString origin;
   nsresult rv = aPrincipal->GetOrigin(origin);
   if (NS_WARN_IF(NS_FAILED(rv))) {
     aKey.Truncate();
     return;
   }
   GetKeyForOrigin(origin, aKey);
 }
 
-/* static */ void nsPermissionManager::GetKeyForPermission(
-    nsIPrincipal* aPrincipal, const nsACString& aType, nsACString& aKey) {
+/* static */
+void nsPermissionManager::GetKeyForPermission(nsIPrincipal* aPrincipal,
+                                              const nsACString& aType,
+                                              nsACString& aKey) {
   // Preload permissions have the "" key.
   if (IsPreloadPermission(aType)) {
     aKey.Truncate();
     return;
   }
 
   GetKeyForPrincipal(aPrincipal, aKey);
 }
 
-/* static */ nsTArray<nsCString> nsPermissionManager::GetAllKeysForPrincipal(
+/* static */
+nsTArray<nsCString> nsPermissionManager::GetAllKeysForPrincipal(
     nsIPrincipal* aPrincipal) {
   MOZ_ASSERT(aPrincipal);
 
   nsTArray<nsCString> keys;
   nsCOMPtr<nsIPrincipal> prin = aPrincipal;
   while (prin) {
     // Add the key to the list
     nsCString* key = keys.AppendElement();