Bug 1528286. Remove bogus comment. r=froydnj
authorBoris Zbarsky <bzbarsky@mit.edu>
Fri, 15 Feb 2019 16:25:06 +0000
changeset 517442 23f41d068c945fffba31d27c126d1603a91ac212
parent 517441 18f508db5b64e076ed9a1b2b71a1cceef03ccfea
child 517443 27ab5f5e1fd4c759a4161b2a3dad96254292a0ed
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1528286
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1528286. Remove bogus comment. r=froydnj There are no relocations needed for string constants. Differential Revision: https://phabricator.services.mozilla.com/D19956
dom/bindings/Codegen.py
--- a/dom/bindings/Codegen.py
+++ b/dom/bindings/Codegen.py
@@ -1857,18 +1857,16 @@ class CGClassConstructor(CGAbstractStati
             ctorName = self.descriptor.interface.identifier.name
 
         preamble = fill(
             """
             JS::CallArgs args = JS::CallArgsFromVp(argc, vp);
             JS::Rooted<JSObject*> obj(cx, &args.callee());
             $*{chromeOnlyCheck}
             if (!args.isConstructing()) {
-              // XXXbz wish I could get the name from the callee instead of
-              // Adding more relocations
               return ThrowConstructorWithoutNew(cx, "${ctorName}");
             }
 
             JS::Rooted<JSObject*> desiredProto(cx);
             if (!GetDesiredProto(cx, args, &desiredProto)) {
               return false;
             }
             """,