Bug 1508257 - Remove io.activity.intervalMilliseconds - r=valentin
authorTarek Ziadé <tarek@mozilla.com>
Mon, 19 Nov 2018 14:52:26 +0000
changeset 503455 23f1f900d990a4b0d3156959a02ab18ff7cf8f39
parent 503454 56372a3d2856e55d259e52b063364d3b0600ba73
child 503456 d765759658a28e9be580381abeca165cb661a0bd
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersvalentin
bugs1508257
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1508257 - Remove io.activity.intervalMilliseconds - r=valentin This preference is not used. Let's get rid of it. Differential Revision: https://phabricator.services.mozilla.com/D12295
modules/libpref/init/all.js
netwerk/base/nsPISocketTransportService.idl
netwerk/test/unit/test_network_activity.js
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -5290,26 +5290,16 @@ pref("memory.blob_report.stack_frames", 
 
 // Disable idle observer fuzz, because only privileged content can access idle
 // observers (bug 780507).
 pref("dom.idle-observers-api.fuzz_time.disabled", true);
 
 // Activates the activity monitor
 pref("io.activity.enabled", false);
 
-// Minimum delay in milliseconds between I/O activity notifications (0 means
-// no notifications). I/O activity includes socket and disk files.
-//
-// The delay is the same for both read and write, though
-// they are handled separately. This pref is only read once at startup:
-// a restart is required to enable a new value.
-//
-// io.activity.enabled needs to be set to true
-pref("io.activity.intervalMilliseconds", 0);
-
 // If true, reuse the same global for (almost) everything loaded by the component
 // loader (JS components, JSMs, etc). This saves memory, but makes it possible
 // for the scripts to interfere with each other.  A restart is required for this
 // to take effect.
 pref("jsloader.shareGlobal", true);
 
 // Whether we should show the placeholder when the element is focused but empty.
 pref("dom.placeholder.show_on_focus", true);
--- a/netwerk/base/nsPISocketTransportService.idl
+++ b/netwerk/base/nsPISocketTransportService.idl
@@ -48,19 +48,13 @@ interface nsPISocketTransportService : n
 };
 
 %{C++
 /*
  * I/O activity observer topic. Sends out information about the
  * amount of data we're sending/receiving via sockets and disk files.
  *
  * Activated via the "io.activity.enabled" preference.
- *
- * when "io.activity.intervalMilliseconds" is > 0, automatically sends
- * out this topic no more than every intervalMilliseconds.
- *
- * if "io.activity.intervalMilliseconds" is 0, notifications are triggered
- * manually via IOActivityMonitor::NotifyActivities()
  */
 #define NS_IO_ACTIVITY "io-activity"
 
 
 %}
--- a/netwerk/test/unit/test_network_activity.js
+++ b/netwerk/test/unit/test_network_activity.js
@@ -28,17 +28,16 @@ function handler(metadata, response) {
 }
 
 async function checkValueAndTrigger(request, data) {
     // give Firefox 150 ms to send notifications out
     do_timeout(150, doTest);
 }
 
 function doTest() {
-    prefs.clearUserPref("network.activity.intervalMilliseconds");
     ok(results.length > 0);
     ok(results[0].host == "127.0.0.1");
     ok(results[0].rx > 0 || results[0].tx > 0);
     httpserver.stop(do_test_finished);
 }
 
 function run_test() {
   // setting up an observer
@@ -46,19 +45,16 @@ function run_test() {
     subject.QueryInterface(Ci.nsIMutableArray);
     for (let data of subject.enumerate()) {
         results.push(data);
     }
   };
 
   Services.obs.addObserver(networkActivity, 'network-activity');
 
-  // send events every 100ms
-  prefs.setIntPref("network.activity.intervalMilliseconds", 100);
-
   // why do I have to do this ??
   Services.obs.notifyObservers(null, "profile-initial-state", null);
 
   do_test_pending();
   httpserver.registerPathHandler("/ok", handler);
   httpserver.start(-1);
   var channel = createChannel();
   channel.asyncOpen2(new ChannelListener(checkValueAndTrigger, null));