Bug 1551416 - increase the test wait time before continuing downloads and update checks. r=bytesized
authorRobert Strong <robert.bugzilla@gmail.com>
Wed, 15 May 2019 17:49:22 +0000
changeset 532798 23e99af8279d9e9dff4e8e2f748c162d92ccde74
parent 532797 73ead3a81fdf357101987a2796c7c1c1b24dc2bd
child 532799 30ee2053caf27c743cb02d8355da879ec8310465
push id11272
push userapavel@mozilla.com
push dateThu, 16 May 2019 15:28:22 +0000
treeherdermozilla-beta@2265bfc5920d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbytesized
bugs1551416
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1551416 - increase the test wait time before continuing downloads and update checks. r=bytesized Tests intermittently fail on code coverage builds due to the additional time they take to run when compared to other builds Differential Revision: https://phabricator.services.mozilla.com/D31264
toolkit/mozapps/update/tests/browser/app_update.sjs
toolkit/mozapps/update/tests/browser/head.js
--- a/toolkit/mozapps/update/tests/browser/app_update.sjs
+++ b/toolkit/mozapps/update/tests/browser/app_update.sjs
@@ -45,17 +45,17 @@ scriptFile = getTestDataFile("sharedUpda
 loadHelperScript(scriptFile);
 
 const SERVICE_URL = URL_HOST + "/" + REL_PATH_DATA + FILE_SIMPLE_MAR;
 const BAD_SERVICE_URL = URL_HOST + "/" + REL_PATH_DATA + "not_here.mar";
 
 // A value of 10 caused the tests to intermittently fail on Mac OS X so be
 // careful when changing this value.
 const SLOW_RESPONSE_INTERVAL = 100;
-const MAX_SLOW_RESPONSE_RETRIES = 50;
+const MAX_SLOW_RESPONSE_RETRIES = 200;
 var gSlowDownloadTimer;
 var gSlowCheckTimer;
 
 function handleRequest(aRequest, aResponse) {
   let params = { };
   if (aRequest.queryString) {
     params = parseQueryString(aRequest.queryString);
   }
--- a/toolkit/mozapps/update/tests/browser/head.js
+++ b/toolkit/mozapps/update/tests/browser/head.js
@@ -109,20 +109,20 @@ registerCleanupFunction(async () => {
  *         Resolves when the file is deleted or if the file is not deleted when
  *         the check for the file's existence times out. If the file isn't
  *         deleted before the check for the file's existence times out it will
  *         be deleted when the test ends so it doesn't affect tests that run
  *         after the test that created the continue file.
  * @throws If the file already exists.
  */
 async function continueFileHandler(leafName) {
-  // The total time to wait with 200 retries and the default interval of 100 is
-  // approximately 20 seconds.
+  // The total time to wait with 300 retries and the default interval of 100 is
+  // approximately 30 seconds.
   let interval = 100;
-  let retries = 200;
+  let retries = 300;
   let continueFile;
   if (leafName == CONTINUE_STAGING) {
     // The total time to wait with 600 retries and an interval of 200 is
     // approximately 120 seconds.
     interval = 200;
     retries = 600;
     continueFile = getGREBinDir();
     continueFile.append(leafName);