Bug 1289366 - added return statement for CharToByte when assertion fails. r=keeler
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Tue, 26 Jul 2016 12:48:49 +0300
changeset 346765 232175372fa0ad56a86a769ae187d8a19abe4c4b
parent 346764 64c473c3414f8f837e5f524f4e484e562d1d405a
child 346766 5265995a809ba2d19ac58b0f9533c7f5cb97c567
push id6389
push userraliiev@mozilla.com
push dateMon, 19 Sep 2016 13:38:22 +0000
treeherdermozilla-beta@01d67bfe6c81 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskeeler
bugs1289366
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1289366 - added return statement for CharToByte when assertion fails. r=keeler MozReview-Commit-ID: LDAamOxHdli
security/certverifier/tests/gtest/CTTestUtils.cpp
--- a/security/certverifier/tests/gtest/CTTestUtils.cpp
+++ b/security/certverifier/tests/gtest/CTTestUtils.cpp
@@ -120,16 +120,17 @@ CharToByte(char c)
   if (c >= '0' && c <= '9') {
     return c - '0';
   } else if (c >= 'a' && c <= 'f') {
     return c - 'a' + 10;
   } else if (c >= 'A' && c <= 'F') {
     return c - 'A' + 10;
   }
   MOZ_RELEASE_ASSERT(false);
+  return 0;
 }
 
 static Buffer
 HexToBytes(const char* hexData)
 {
   size_t hexLen = strlen(hexData);
   MOZ_RELEASE_ASSERT(hexLen > 0 && (hexLen % 2 == 0));
   size_t resultLen = hexLen / 2;