Bug 1531437 - Remove compatibility workaround for validating property names.
authorAndrew Law <andrewcylaw@hotmail.com>
Mon, 11 Mar 2019 16:22:19 -0400
changeset 521363 211218d95e2c
parent 521362 f8f1b79cbc42
child 521364 a4438c2ef6a3
push id10866
push usernerli@mozilla.com
push dateTue, 12 Mar 2019 18:59:09 +0000
treeherdermozilla-beta@445c24a51727 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1531437
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1531437 - Remove compatibility workaround for validating property names.
devtools/client/inspector/rules/models/text-property.js
--- a/devtools/client/inspector/rules/models/text-property.js
+++ b/devtools/client/inspector/rules/models/text-property.js
@@ -243,18 +243,13 @@ class TextProperty {
     // When adding a new property in the rule-view, the TextProperty object is
     // created right away before the rule gets updated on the server, so we're
     // not going to find the corresponding declaration object yet. Default to
     // true.
     if (!this.rule.domRule.declarations[selfIndex]) {
       return true;
     }
 
-    // Starting with FF61, StyleRuleActor provides an accessor to signal if the property
-    // name is valid. If we don't have this, assume the name is valid. In use, rely on
-    // isValid() as a guard against false positives.
-    return (this.rule.domRule.declarations[selfIndex].isNameValid !== undefined)
-      ? this.rule.domRule.declarations[selfIndex].isNameValid
-      : true;
+    return this.rule.domRule.declarations[selfIndex].isNameValid;
   }
 }
 
 module.exports = TextProperty;