Bug 1502355 - Declare |JSClass| in consistent fashion everywhere. r=arai
authorJeff Walden <jwalden@mit.edu>
Tue, 18 Aug 2020 20:50:07 +0000
changeset 609847 207f8942ffd2518de32429475f6d89860c9cc24d
parent 609846 3755692f8d5f4bc8527ce99aa87884e002a12493
child 609848 eeff6597f16f39192c4e05c5155b09163b719aa6
push id13553
push userffxbld-merge
push dateMon, 24 Aug 2020 12:51:36 +0000
treeherdermozilla-beta@a54f8b5d0977 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersarai
bugs1502355
milestone81.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1502355 - Declare |JSClass| in consistent fashion everywhere. r=arai Differential Revision: https://phabricator.services.mozilla.com/D87376
js/public/TypeDecls.h
js/src/builtin/intl/DisplayNames.h
js/src/jspubtd.h
--- a/js/public/TypeDecls.h
+++ b/js/public/TypeDecls.h
@@ -22,17 +22,17 @@
 
 #include "js-config.h"
 #include "jstypes.h"
 
 typedef uint8_t jsbytecode;
 
 class JS_PUBLIC_API JSAtom;
 struct JS_PUBLIC_API JSContext;
-struct JS_PUBLIC_API JSClass;
+struct JSClass;
 class JS_PUBLIC_API JSFunction;
 class JS_PUBLIC_API JSFreeOp;
 class JS_PUBLIC_API JSObject;
 struct JS_PUBLIC_API JSRuntime;
 class JS_PUBLIC_API JSScript;
 class JS_PUBLIC_API JSString;
 
 namespace js {
--- a/js/src/builtin/intl/DisplayNames.h
+++ b/js/src/builtin/intl/DisplayNames.h
@@ -11,23 +11,22 @@
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "jstypes.h"
 #include "NamespaceImports.h"
 
 #include "builtin/SelfHostingDefines.h"
+#include "js/Class.h"  // JSClass, JSClassOps, js::ClassSpec
 #include "js/Value.h"
 #include "vm/JSObject.h"
 #include "vm/List.h"
 #include "vm/NativeObject.h"
 
-struct JS_PUBLIC_API JSClass;
-struct JSClassOps;
 struct JS_PUBLIC_API JSContext;
 class JS_PUBLIC_API JSFreeOp;
 
 struct ULocaleDisplayNames;
 
 namespace js {
 struct ClassSpec;
 
--- a/js/src/jspubtd.h
+++ b/js/src/jspubtd.h
@@ -48,17 +48,17 @@ enum JSType {
 enum JSProtoKey {
 #define PROTOKEY_AND_INITIALIZER(name, clasp) JSProto_##name,
   JS_FOR_EACH_PROTOTYPE(PROTOKEY_AND_INITIALIZER)
 #undef PROTOKEY_AND_INITIALIZER
       JSProto_LIMIT
 };
 
 /* Struct forward declarations. */
-struct JS_PUBLIC_API JSClass;
+struct JSClass;
 class JSErrorReport;
 struct JSFunctionSpec;
 struct JSPrincipals;
 struct JSPropertySpec;
 struct JSSecurityCallbacks;
 struct JSStructuredCloneCallbacks;
 struct JSStructuredCloneReader;
 struct JSStructuredCloneWriter;