Bug 1498233 - Stub out getBrowserForOuterWindowID for GeckoViewTab. r=jchen
authorMike Conley <mconley@mozilla.com>
Tue, 06 Nov 2018 04:35:00 +0000
changeset 501109 1fafb01078dbb3602bcdac29d40f91f67f71fba3
parent 501108 74780d0a4848ac873154e4ff95c3287c375b976b
child 501110 63975abdead1d3520fb44711f43496d2ffd11c56
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjchen
bugs1498233
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1498233 - Stub out getBrowserForOuterWindowID for GeckoViewTab. r=jchen GeckoViewTab stubs out gBrowser on the root window for WebExtension compatibility. LoginManagerParent also looks for gBrowser on windows that are handling username and password form fills, and expects it to implement getBrowserForOuterWindowID. This patch makes the stub implement getBrowserForOuterWindowID, which just returns the lone GeckoViewTab browser. Differential Revision: https://phabricator.services.mozilla.com/D10750
mobile/android/modules/geckoview/GeckoViewTab.jsm
--- a/mobile/android/modules/geckoview/GeckoViewTab.jsm
+++ b/mobile/android/modules/geckoview/GeckoViewTab.jsm
@@ -40,11 +40,15 @@ class GeckoViewTab extends GeckoViewModu
 
       getTabForWindow: function(aWindow) {
         return this.selectedTab;
       },
 
       getTabForDocument: function(aDocument) {
         return this.selectedTab;
       },
+
+      getBrowserForOuterWindowID: function(aID) {
+        return this.browser;
+      },
     };
   }
 }