Bug 1368145 - Change 'All Devices' to 'Send to All Devices' with its property name r=eoger
☠☠ backed out by d5c96e74c920 ☠ ☠
authorJeongkyu Kim <jeongkyu.kim@gmail.com>
Fri, 09 Jun 2017 12:25:41 +0900
changeset 411349 1efa46c863a0fcc79dc66757d7e3a22c88475e18
parent 411348 8ae6f0335b204177f90e9c964ede65da3054fe76
child 411350 bf13425e15f781c4616e23aee4484dcac66b1d21
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerseoger
bugs1368145
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1368145 - Change 'All Devices' to 'Send to All Devices' with its property name r=eoger MozReview-Commit-ID: 5g6IuuV51P6
browser/base/content/browser-sync.js
browser/locales/en-US/chrome/browser/accounts.properties
--- a/browser/base/content/browser-sync.js
+++ b/browser/base/content/browser-sync.js
@@ -317,22 +317,22 @@ var gSync = {
       fragment.appendChild(targetDevice);
     }
 
     const clients = this.remoteClients;
     for (let client of clients) {
       addTargetDevice(client.id, client.name, client.type);
     }
 
-    // "All devices" menu item
+    // "Send to All Devices" menu item
     if (clients.length > 1) {
       const separator = createDeviceNodeFn();
       separator.classList.add("sync-menuitem");
       fragment.appendChild(separator);
-      const allDevicesLabel = this.fxaStrings.GetStringFromName("sendTabToAllDevices.menuitem");
+      const allDevicesLabel = this.fxaStrings.GetStringFromName("sendToAllDevices.menuitem");
       addTargetDevice("", allDevicesLabel, "");
     }
 
     devicesPopup.appendChild(fragment);
   },
 
   isSendableURI(aURISpec) {
     if (!aURISpec) {
--- a/browser/locales/en-US/chrome/browser/accounts.properties
+++ b/browser/locales/en-US/chrome/browser/accounts.properties
@@ -30,19 +30,19 @@ syncStartNotification.title = Sync Enabl
 # %S is brandShortName
 syncStartNotification.body2 = %S will begin syncing momentarily.
 
 # LOCALIZATION NOTE (deviceDisconnectedNotification.title, deviceDisconnectedNotification.body)
 # These strings are used in a notification shown after Sync was disconnected remotely.
 deviceDisconnectedNotification.title = Sync disconnected
 deviceDisconnectedNotification.body = This computer has been successfully disconnected from Firefox Sync.
 
-# LOCALIZATION NOTE (sendTabToAllDevices.menuitem)
-# Displayed in the Send Tabs context menu when right clicking a tab, a page or a link.
-sendTabToAllDevices.menuitem = All Devices
+# LOCALIZATION NOTE (sendToAllDevices.menuitem)
+# Displayed in the Send Page to Device context menu when right clicking a tab, a page or a link.
+sendToAllDevices.menuitem = Send to All Devices
 
 # LOCALIZATION NOTE (tabArrivingNotification.title, tabArrivingNotificationWithDevice.title,
 # tabsArrivingNotification.title, unnamedTabsArrivingNotification2.body,
 # unnamedTabsArrivingNotificationMultiple2.body, unnamedTabsArrivingNotificationNoDevice.body)
 # These strings are used in a notification shown when we're opening tab(s) another device sent us to display.
 
 # LOCALIZATION NOTE (tabArrivingNotification.title, tabArrivingNotificationWithDevice.title)
 # The body for these is the URL of the tab recieved