☠☠ backed out by e3cec7443adf ☠ ☠ | |
author | Brian Hackett <bhackett1024@gmail.com> |
Wed, 08 Aug 2018 16:43:56 +0000 | |
changeset 486204 | 1ec7f635f4f371bd95b494f68583047d49ca7ee8 |
parent 486202 | 39ad7ffcd976cb51d908f139c9d19f1e112ee4f5 |
child 486205 | 58598aa3cf0cf9ea6508314bed448a6fbe3b0654 |
push id | 9719 |
push user | ffxbld-merge |
push date | Fri, 24 Aug 2018 17:49:46 +0000 |
treeherder | mozilla-beta@719ec98fba77 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | gsvelto |
bugs | 1481009 |
milestone | 63.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/toolkit/xre/nsEmbedFunctions.cpp +++ b/toolkit/xre/nsEmbedFunctions.cpp @@ -290,20 +290,17 @@ XRE_TakeMinidumpForChild(uint32_t aChild bool #if defined(XP_WIN) XRE_SetRemoteExceptionHandler(const char* aPipe /*= 0*/, uintptr_t aCrashTimeAnnotationFile) #else XRE_SetRemoteExceptionHandler(const char* aPipe /*= 0*/) #endif { - // Crash reporting is disabled for now when recording or replaying executions. - if (recordreplay::IsRecordingOrReplaying() || recordreplay::IsMiddleman()) { - return true; - } + recordreplay::AutoPassThroughThreadEvents pt; #if defined(XP_WIN) return CrashReporter::SetRemoteExceptionHandler(nsDependentCString(aPipe), aCrashTimeAnnotationFile); #elif defined(XP_MACOSX) return CrashReporter::SetRemoteExceptionHandler(nsDependentCString(aPipe)); #else return CrashReporter::SetRemoteExceptionHandler(); #endif