Bug 1491572 - Add a reason string to added MOZ_ASSERT_UNREACHABLE. r=me
authorBobby Holley <bobbyholley@gmail.com>
Sun, 16 Sep 2018 10:10:43 -0700
changeset 492378 1e167ef58df92afd693b415023cb2aa65b92e465
parent 492360 7ed950e60f3c1f8a47c117c04124d31e94a66e32
child 492379 5165e750ffabb930deb846410ab62dcc6d1f9e52
child 492381 b4f8cb6afab6ac2f647a17b8f20478afb332e517
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1491572
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1491572 - Add a reason string to added MOZ_ASSERT_UNREACHABLE. r=me MozReview-Commit-ID: EpS5ubqYGec
gfx/layers/ipc/CompositorManagerParent.cpp
--- a/gfx/layers/ipc/CompositorManagerParent.cpp
+++ b/gfx/layers/ipc/CompositorManagerParent.cpp
@@ -320,17 +320,17 @@ CompositorManagerParent::RecvReportMemor
   // thread, so we can't just pass it over to the renderer thread. We use
   // an intermediate MozPromise instead.
   wr::RenderThread::AccumulateMemoryReport(aggregate)->Then(
     CompositorThreadHolder::Loop()->SerialEventTarget(), __func__,
     [resolver = std::move(aResolver)](MemoryReport aReport) {
       resolver(aReport);
     },
     [](bool) {
-      MOZ_ASSERT_UNREACHABLE();
+      MOZ_ASSERT_UNREACHABLE("MemoryReport promises are never rejected");
     }
   );
 
   return IPC_OK();
 }
 
 } // namespace layers
 } // namespace mozilla