Backed out changeset 0e6973ba9fe5 (bug 1526045) for build bustages at gfxPlatform.cpp. CLOSED TREE
authorBrindusan Cristian <cbrindusan@mozilla.com>
Tue, 26 Feb 2019 08:56:06 +0200
changeset 519018 1de4e8186b7fdbbb35a2dbd3f0b934be31166814
parent 519017 0e6973ba9fe579d79bd2845fabb5e17179b33af7
child 519019 3098f2ba2d33867e1b6d4a255575b9724f929930
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1526045
milestone67.0a1
backs out0e6973ba9fe579d79bd2845fabb5e17179b33af7
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 0e6973ba9fe5 (bug 1526045) for build bustages at gfxPlatform.cpp. CLOSED TREE
gfx/thebes/gfxPlatform.cpp
--- a/gfx/thebes/gfxPlatform.cpp
+++ b/gfx/thebes/gfxPlatform.cpp
@@ -1739,30 +1739,17 @@ already_AddRefed<DrawTarget> gfxPlatform
   return CreateDrawTargetForBackend(mFallbackCanvasBackend, aSize, aFormat);
 #endif
 }
 
 already_AddRefed<DrawTarget> gfxPlatform::CreateOffscreenContentDrawTarget(
     const IntSize& aSize, SurfaceFormat aFormat, bool aFallback) {
   BackendType backend = (aFallback) ? mSoftwareBackend : mContentBackend;
   NS_ASSERTION(backend != BackendType::NONE, "No backend.");
-  RefPtr<DrawTarget> dt = CreateDrawTargetForBackend(backend, aSize, aFormat);
-
-  if (!dt) {
-    return nullptr;
-  }
-
-  // We'd prefer this to take proper care and return a CaptureDT, but for the
-  // moment since we can't and this means we're going to be drawing on the main
-  // thread force it's initialization. See bug 1526045 and bug 1521368.
-  dt->ClearRect(Rect());
-  if (!dt->IsValid()) {
-    return nullptr;
-  }
-  return dt.forget();
+  return CreateDrawTargetForBackend(backend, aSize, aFormat);
 }
 
 already_AddRefed<DrawTarget> gfxPlatform::CreateSimilarSoftwareDrawTarget(
     DrawTarget* aDT, const IntSize& aSize, SurfaceFormat aFormat) {
   RefPtr<DrawTarget> dt;
 
   if (Factory::DoesBackendSupportDataDrawtarget(aDT->GetBackendType())) {
     dt = aDT->CreateSimilarDrawTarget(aSize, aFormat);