Bug 1068739 - Record position of search suggestion that was tapped in telemetry. r=mfinkle
authorMargaret Leibovic <margaret.leibovic@gmail.com>
Fri, 03 Oct 2014 14:37:19 -0400
changeset 231953 1cacd42c198b239221336559794dc3446e75ba80
parent 231952 cd21b9eee1a5758fe460f8a9cbcb7b6b6d14e4ef
child 231954 d1094a154b4135ddda9650c6f82f9e990a675077
push id4187
push userbhearsum@mozilla.com
push dateFri, 28 Nov 2014 15:29:12 +0000
treeherdermozilla-beta@f23cc6a30c11 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle
bugs1068739
milestone35.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1068739 - Record position of search suggestion that was tapped in telemetry. r=mfinkle
mobile/android/search/java/org/mozilla/search/autocomplete/SuggestionsFragment.java
--- a/mobile/android/search/java/org/mozilla/search/autocomplete/SuggestionsFragment.java
+++ b/mobile/android/search/java/org/mozilla/search/autocomplete/SuggestionsFragment.java
@@ -104,17 +104,17 @@ public class SuggestionsFragment extends
             @Override
             public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
                 final Suggestion suggestion = (Suggestion) suggestionsList.getItemAtPosition(position);
 
                 final Rect startBounds = new Rect();
                 view.getGlobalVisibleRect(startBounds);
 
                 // The user tapped on a suggestion from the search engine.
-                Telemetry.sendUIEvent(TelemetryContract.Event.SEARCH, TelemetryContract.Method.SUGGESTION, "suggest");
+                Telemetry.sendUIEvent(TelemetryContract.Event.SEARCH, TelemetryContract.Method.SUGGESTION, position);
 
                 searchListener.onSearch(suggestion.value, new SuggestionAnimation() {
                     @Override
                     public Rect getStartBounds() {
                         return startBounds;
                     }
                 });
             }