Bug 1388514 - Make the sidebar splitter narrower again to prevent it from overlapping the scrollbar too much, and disable this behavior on Linux since scrollbars are too narrow on Ubuntu. r=Gijs
authorDão Gottwald <dao@mozilla.com>
Thu, 07 Sep 2017 20:22:58 +0200
changeset 428994 1c37a53a0c8fd953956f80d75c10b6088a5f34bb
parent 428993 aa9f9146b198aaacafff5f037b5410f2f7a754cd
child 428995 4e40392db1f5f11fbc9f892b096f9ae351fd6013
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1388514
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1388514 - Make the sidebar splitter narrower again to prevent it from overlapping the scrollbar too much, and disable this behavior on Linux since scrollbars are too narrow on Ubuntu. r=Gijs MozReview-Commit-ID: Hi4MUsbEFXd
browser/themes/linux/browser.css
browser/themes/shared/sidebar.inc.css
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -582,17 +582,21 @@ html|span.ac-emphasize-text-url {
   color: -moz-FieldText;
 }
 
 #sidebar-header {
   border-bottom: 1px solid ThreeDShadow;
 }
 
 .sidebar-splitter {
-  border-color: ThreeDShadow;
+  -moz-appearance: none;
+  width: 6px;
+  background-color: -moz-dialog;
+  border: 1px ThreeDShadow;
+  border-style: none solid;
 }
 
 .browserContainer > findbar {
   background-color: -moz-dialog;
   color: -moz-DialogText;
   text-shadow: none;
 }
 
--- a/browser/themes/shared/sidebar.inc.css
+++ b/browser/themes/shared/sidebar.inc.css
@@ -6,34 +6,38 @@
 
 .sidebar-header,
 #sidebar-header {
   font-size: 1.333em;
   font-weight: lighter;
   padding: 8px;
 }
 
+%ifndef MOZ_WIDGET_GTK
+% We don't let the splitter overlap the sidebar on Linux since the sidebar's
+% scrollbar is too narrow on Linux.
 .sidebar-splitter {
   -moz-appearance: none;
   border: 0 solid;
   border-inline-end-width: 1px;
   min-width: 1px;
-  width: 8px;
+  width: 4px;
   background-image: none !important;
   background-color: transparent;
-  margin-inline-start: -8px;
+  margin-inline-start: -4px;
   position: relative;
 }
 
 #sidebar-box[positionend] + .sidebar-splitter {
   border-inline-end-width: 0;
   border-inline-start-width: 1px;
   margin-inline-start: 0;
-  margin-inline-end: -8px;
+  margin-inline-end: -4px;
 }
+%endif
 
 #sidebar-throbber[loading="true"] {
   list-style-image: url("chrome://global/skin/icons/loading.png");
 }
 
 @media (min-resolution: 2dppx) {
   .sidebar-throbber[loading="true"],
   #sidebar-throbber[loading="true"] {