Bug 1130203 - Remove dividers in share overlay. r=mhaigh
authorMichael Comella <michael.l.comella@gmail.com>
Thu, 26 Feb 2015 18:35:56 -0800
changeset 264365 1c34fab43fa42993cce29b55856b55d262e9887a
parent 264364 ba4e9c9171996dadc76d330d01588863ba54bc0c
child 264366 7f0f273c14a747a9bbc7c1119f960fa2b7d799d5
push id4718
push userraliiev@mozilla.com
push dateMon, 11 May 2015 18:39:53 +0000
treeherdermozilla-beta@c20c4ef55f08 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhaigh
bugs1130203
milestone39.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1130203 - Remove dividers in share overlay. r=mhaigh
mobile/android/base/resources/layout/overlay_share_dialog.xml
--- a/mobile/android/base/resources/layout/overlay_share_dialog.xml
+++ b/mobile/android/base/resources/layout/overlay_share_dialog.xml
@@ -42,43 +42,29 @@
         <!-- Buttons -->
         <LinearLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_marginTop="20dp"
             android:background="@color/overlay_share_background"
             android:orientation="vertical">
 
-            <!-- TODO: Once API 11 is available, stick "showDividers=middle" into the parent and get rid
-                       of these evil separator views. -->
-
             <!-- "Send to Firefox Sync" -->
             <org.mozilla.gecko.overlays.ui.SendTabList
                 style="@style/ShareOverlayButton"
                 android:id="@+id/overlay_send_tab_btn"
-                android:padding="0dp"/>
-
-            <!-- Evil separator -->
-            <View
-                android:layout_width="match_parent"
-                android:layout_height="1dp"
-                android:background="@color/background_light"/>
+                android:padding="0dp"
+                android:divider="@null"/>
 
             <!-- "Add to reading list" -->
             <org.mozilla.gecko.overlays.ui.OverlayDialogButton
                 style="@style/ShareOverlayButton.Text.Container"
                 android:id="@+id/overlay_share_reading_list_btn"
                 android:enabled="false"/>
 
-            <!-- Evil separator -->
-            <View
-                android:layout_width="match_parent"
-                android:layout_height="1dp"
-                android:background="@color/background_light"/>
-
             <!-- "Add bookmark" -->
             <org.mozilla.gecko.overlays.ui.OverlayDialogButton
                 style="@style/ShareOverlayButton.Text.Container"
                 android:id="@+id/overlay_share_bookmark_btn"
                 android:enabled="false"/>
 
         </LinearLayout>
     </LinearLayout>