Bug 1398379 part 2: Remove GetRootScrollFrameAsScrollableExternal() since it has no more callers. r=mats
authorDaniel Holbert <dholbert@cs.stanford.edu>
Fri, 08 Sep 2017 16:36:34 -0700
changeset 429330 1bf55ab6c1c70e1c2db229c17c7ab46f355aaf44
parent 429329 6e962926d2f8ce0a23471864a30f6eb99248ab74
child 429331 97dbcd99280dad5c762e10e596e39f286772348e
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmats
bugs1398379
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1398379 part 2: Remove GetRootScrollFrameAsScrollableExternal() since it has no more callers. r=mats MozReview-Commit-ID: 5m6p7sS2jRS
layout/base/PresShell.cpp
layout/base/nsIPresShell.h
--- a/layout/base/PresShell.cpp
+++ b/layout/base/PresShell.cpp
@@ -2471,22 +2471,16 @@ nsIPresShell::GetRootScrollFrameAsScroll
   if (!frame)
     return nullptr;
   nsIScrollableFrame* scrollableFrame = do_QueryFrame(frame);
   NS_ASSERTION(scrollableFrame,
                "All scroll frames must implement nsIScrollableFrame");
   return scrollableFrame;
 }
 
-nsIScrollableFrame*
-nsIPresShell::GetRootScrollFrameAsScrollableExternal() const
-{
-  return GetRootScrollFrameAsScrollable();
-}
-
 nsIPageSequenceFrame*
 PresShell::GetPageSequenceFrame() const
 {
   nsIFrame* frame = mFrameConstructor->GetPageSequenceFrame();
   return do_QueryFrame(frame);
 }
 
 nsCanvasFrame*
--- a/layout/base/nsIPresShell.h
+++ b/layout/base/nsIPresShell.h
@@ -397,22 +397,16 @@ public:
    */
   nsIFrame* GetRootScrollFrame() const;
 
   /*
    * The same as GetRootScrollFrame, but returns an nsIScrollableFrame
    */
   nsIScrollableFrame* GetRootScrollFrameAsScrollable() const;
 
-  /*
-   * The same as GetRootScrollFrame, but returns an nsIScrollableFrame.
-   * Can be called by code not linked into gklayout.
-   */
-  virtual nsIScrollableFrame* GetRootScrollFrameAsScrollableExternal() const;
-
   /**
    * Get the current focused content or DOM selection that should be the
    * target for scrolling.
    */
   already_AddRefed<nsIContent> GetContentForScrolling() const;
 
   /**
    * Get the DOM selection that should be the target for scrolling, if there