Bug 1506118 - Use chromeUtilsWindow to start the parser worker; r=Honza.
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Mon, 19 Nov 2018 16:33:22 +0000
changeset 503448 1bd7fb2e62580ec67db80611659ca162293df0ba
parent 503447 b3787ede5d7baf7e6490758ec5898bd94cb9b123
child 503449 4b7c53151158f12abeadcd76779a26a94a9fd26b
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1506118
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1506118 - Use chromeUtilsWindow to start the parser worker; r=Honza. As we were using the browserWindow to start the parser worker, this was causing an exception when evaluation from the browser toolbox. Using chromUtilsWindow fixes the issue. There is no tests yet as I'm not sure there's an easy way to test things in the browser toolbox. Differential Revision: https://phabricator.services.mozilla.com/D12101
devtools/client/webconsole/webconsole.js
--- a/devtools/client/webconsole/webconsole.js
+++ b/devtools/client/webconsole/webconsole.js
@@ -267,17 +267,17 @@ WebConsole.prototype = {
       return this._parserService;
     }
 
     this._parserService =
       require("devtools/client/debugger/new/src/workers/parser/index");
 
     this._parserService.start(
       "resource://devtools/client/debugger/new/dist/parser-worker.js",
-      this.browserWindow);
+      this.chromeUtilsWindow);
     return this._parserService;
   },
 
   /**
    * Retrieves the current selection from the Inspector, if such a selection
    * exists. This is used to pass the ID of the selected actor to the Web
    * Console server for the $0 helper.
    *