Bug 1374837 - Pipe stderr to stdout to fix the Browser Toolbox in certain Windows builds;r=kmag
authorBrian Grinstead <bgrinstead@mozilla.com>
Mon, 11 Sep 2017 11:34:21 -0700
changeset 429637 1bc15f7fe1af609e913489d6f615b6d41701c731
parent 429636 6616cbb6460fdf486e447248aec1f9803db4acdb
child 429638 0ef39e821b67496cfb9e29de90367952e1a5174f
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskmag
bugs1374837
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1374837 - Pipe stderr to stdout to fix the Browser Toolbox in certain Windows builds;r=kmag This is working around an issue with Subprocess that affects some developers using a 32 bit build on a 64 bit Windows MozReview-Commit-ID: COsKOkBVjSZ
devtools/client/framework/ToolboxProcess.jsm
--- a/devtools/client/framework/ToolboxProcess.jsm
+++ b/devtools/client/framework/ToolboxProcess.jsm
@@ -272,16 +272,17 @@ BrowserToolboxProcess.prototype = {
     if (!system.constants.MOZILLA_OFFICIAL) {
       args.push("-purgecaches");
     }
 
     this._dbgProcessPromise = Subprocess.call({
       command,
       arguments: args,
       environmentAppend: true,
+      stderr: "stdout",
       environment: {
         // Disable safe mode for the new process in case this was opened via the
         // keyboard shortcut.
         MOZ_DISABLE_SAFE_MODE_KEY: "1",
       },
     }).then(proc => {
       this._dbgProcess = proc;