Bug 1472496 - Don't call out to readelf in check_binary.py. r=mshal
authorPaul Adenot <paul@paul.cx>
Mon, 01 Oct 2018 13:26:35 +0000
changeset 494708 1b9e4b90413f4250f4544d80a8a61c8e03895121
parent 494707 a350fbc271e9adf9fe2de25c45d5d578f00cf03e
child 494709 351f159a3fd8b9bdd6916fb99c795501f1f261e5
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmshal
bugs1472496
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1472496 - Don't call out to readelf in check_binary.py. r=mshal Differential Revision: https://phabricator.services.mozilla.com/D6892
python/mozbuild/mozbuild/action/check_binary.py
--- a/python/mozbuild/mozbuild/action/check_binary.py
+++ b/python/mozbuild/mozbuild/action/check_binary.py
@@ -297,20 +297,25 @@ def checks(target, binary):
     # Cheat and pretend we were passed the right argument.
     if 'clang-plugin' in binary:
         target = HOST
     checks = []
     if target['MOZ_LIBSTDCXX_VERSION']:
         checks.append(check_stdcxx)
         checks.append(check_libgcc)
         checks.append(check_glibc)
-    checks.append(check_textrel)
+
+    # Disabled for local builds because of readelf performance: See bug 1472496
+    if not buildconfig.substs.get('DEVELOPER_OPTIONS'):
+        checks.append(check_textrel)
+        checks.append(check_pt_load)
+        checks.append(check_mozglue_order)
+
     checks.append(check_nsmodules)
-    checks.append(check_pt_load)
-    checks.append(check_mozglue_order)
+
     retcode = 0
     basename = os.path.basename(binary)
     for c in checks:
         try:
             name = c.__name__
             c(target, binary)
             if buildconfig.substs.get('MOZ_AUTOMATION'):
                 print('TEST-PASS | {} | {}'.format(name, basename))