Bug 1322746 - No fast uploads for x/y/zOffset!=0 yet. - r=daoshengmu
authorJeff Gilbert <jgilbert@mozilla.com>
Thu, 31 Aug 2017 13:38:23 -0700
changeset 427979 1b61f5cdc350d499a2999fb10b794b74a913b5ff
parent 427978 7715e44f38eff05daf8ef171b45dd785b67d6a7e
child 427980 ebb37ec59e76cfea762478534944cc6c41e77a21
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdaoshengmu
bugs1322746
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1322746 - No fast uploads for x/y/zOffset!=0 yet. - r=daoshengmu MozReview-Commit-ID: CVq6TYhg9FP
dom/canvas/TexUnpackBlob.cpp
--- a/dom/canvas/TexUnpackBlob.cpp
+++ b/dom/canvas/TexUnpackBlob.cpp
@@ -634,16 +634,20 @@ TexUnpackImage::TexOrSubImage(bool isSub
     }
 
     const char* fallbackReason;
     do {
         if (mDepth != 1) {
             fallbackReason = "depth is not 1";
             break;
         }
+        if (xOffset != 0 || yOffset != 0 || zOffset != 0) {
+            fallbackReason = "x/y/zOffset is not 0";
+            break;
+        }
 
         if (webgl->mPixelStore_UnpackSkipPixels ||
             webgl->mPixelStore_UnpackSkipRows ||
             webgl->mPixelStore_UnpackSkipImages)
         {
             fallbackReason = "non-zero UNPACK_SKIP_* not yet supported";
             break;
         }