Bug 1457086 - Bump the markup badges font-size to 10px on 1dppx screens and 9px for higher resolution screens. r=rcaliman
authorGabriel Luong <gabriel.luong@gmail.com>
Mon, 20 Aug 2018 19:14:19 -0400
changeset 487604 1a8cf32923f8ef0f0ab6d7ed3204086b2a422071
parent 487603 0c6795b35e1a6dec42f784b839511c977c88260f
child 487605 73df3e4f72aa90282e82b4672ea662e74f4698a1
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrcaliman
bugs1457086
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1457086 - Bump the markup badges font-size to 10px on 1dppx screens and 9px for higher resolution screens. r=rcaliman
devtools/client/inspector/markup/test/browser_markup_events-windowed-host.js
devtools/client/themes/markup.css
--- a/devtools/client/inspector/markup/test/browser_markup_events-windowed-host.js
+++ b/devtools/client/inspector/markup/test/browser_markup_events-windowed-host.js
@@ -46,18 +46,18 @@ async function runTests(inspector) {
   await onInspectorUpdated;
 
   ok(tooltip.isVisible(), "EventTooltip visible.");
 
   onInspectorUpdated = inspector.once("inspector-updated");
   const onTooltipHidden = tooltip.once("hidden");
 
   info("Click on another tag to hide the event tooltip");
-  const h1 = await getContainerForSelector("h1", inspector);
-  const tag = h1.elt.querySelector(".tag");
+  const script = await getContainerForSelector("script", inspector);
+  const tag = script.elt.querySelector(".tag");
   EventUtils.synthesizeMouseAtCenter(tag, {}, inspector.markup.doc.defaultView);
 
   await onTooltipHidden;
   // New node is selected, wait for inspector-updated.
   await onInspectorUpdated;
 
   ok(!tooltip.isVisible(), "EventTooltip hidden.");
 }
--- a/devtools/client/themes/markup.css
+++ b/devtools/client/themes/markup.css
@@ -389,29 +389,35 @@ ul.children + .tag-line::before {
 /* Applicable to the DOCTYPE */
 .doctype {
   font-style: italic;
 }
 
 /* Markup Badges */
 .markup-badge {
   display: inline-block;
-  font-size: 9px;
+  font-size: 10px;
   font-weight: normal;
   line-height: 11px;
   vertical-align: 1px;
   border: 1px solid var(--markup-badge-border-color);
   border-radius: 3px;
   padding: 0px 2px;
   margin-inline-start: 5px;
   -moz-user-select: none;
   background-color: var(--markup-badge-background-color);
   color: var(--markup-badge-color);
 }
 
+@media (min-resolution: 1.1dppx) {
+  .markup-badge {
+    font-size: 9px;
+  }
+}
+
 .markup-badge.active {
   background-color: var(--markup-badge-active-background-color);
   border-color: var(--theme-selection-color);
   color: var(--theme-selection-color);
 }
 
 .markup-badge[data-custom],
 .markup-badge[data-display="flex"].interactive,