Bug 1454429. Remove broken paint flashing support.
authorJeff Muizelaar <jmuizelaar@mozilla.com>
Mon, 16 Apr 2018 13:44:58 -0400
changeset 467402 1a6e27a09653b27d965e45bd2838e829a4564ebc
parent 467401 7042561b82de86853d7655b20fc278a3cc335207
child 467403 e9f29bf619f3a2e58e287b8897ac76f2ff22d3e5
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1454429
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1454429. Remove broken paint flashing support. Doing paint flashing here doesn't work with the merging. We'll need to do the flashing when we actually paint the blob. MozReview-Commit-ID: KPujW43upQp
gfx/layers/wr/WebRenderCommandBuilder.cpp
--- a/gfx/layers/wr/WebRenderCommandBuilder.cpp
+++ b/gfx/layers/wr/WebRenderCommandBuilder.cpp
@@ -579,25 +579,16 @@ struct DIGroup
         aWrManager->AddImageKeyForDiscard(mKey.value());
         mKey = Nothing();
       }
       return;
     }
 
     PaintItemRange(aGrouper, aStartItem, aEndItem, context, recorder);
 
-    if (aStartItem->Frame()->PresContext()->GetPaintFlashing()) {
-      context->SetMatrix(Matrix());
-      float r = float(rand()) / RAND_MAX;
-      float g = float(rand()) / RAND_MAX;
-      float b = float(rand()) / RAND_MAX;
-      dt->FillRect(gfx::Rect(0, 0, dtSize.width, dtSize.height), gfx::ColorPattern(gfx::Color(r, g, b, 0.5)));
-      dt->FlushItem(IntRect(IntPoint(0, 0), dtSize));
-    }
-
     // XXX: set this correctly perhaps using aItem->GetOpaqueRegion(aDisplayListBuilder, &snapped).Contains(paintBounds);?
     bool isOpaque = false;
 
     bool hasItems = recorder->Finish();
     GP("%d Finish\n", hasItems);
     Range<uint8_t> bytes((uint8_t*)recorder->mOutputStream.mData, recorder->mOutputStream.mLength);
     if (!mKey) {
       if (!hasItems) // we don't want to send a new image that doesn't have any items in it