Bug 1393577: Change AS context menu title to subdomain.domain.tld. r=liuche
authorMichael Comella <michael.l.comella@gmail.com>
Fri, 08 Sep 2017 14:38:50 -0700
changeset 429395 1a510d80a28f10b8b6ae08b39de5d6b11a4aef9a
parent 429394 27b589b9c3f465a64b416b61ff11d9cf23ae5f84
child 429396 d53ba311ca2f0c3d81d4a5e88a7449c18ec5e4b6
child 429397 d6c9a7de311e5e19a54e7403227c581d377a6718
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersliuche
bugs1393577
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1393577: Change AS context menu title to subdomain.domain.tld. r=liuche Unlike the previous changeset, we don't strip common subdomains because "m.youtube.com" and "www.mozilla.org" can be informative and don't look bad when you have a tld. MozReview-Commit-ID: BOPH73pzAfh
mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/menu/BottomSheetContextMenu.java
--- a/mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/menu/BottomSheetContextMenu.java
+++ b/mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/menu/BottomSheetContextMenu.java
@@ -226,17 +226,17 @@ import java.net.URISyntaxException;
 
     /** Updates the given TextView's text to the page domain. */
     private static class UpdatePageDomainAsyncTask extends URIUtils.GetFormattedDomainAsyncTask {
         private final WeakReference<TextView> pageDomainViewWeakReference;
         private final String[] pageDomainTextReference;
 
         private UpdatePageDomainAsyncTask(final Context context, final TextView pageDomainView, final URI uri,
                 final String[] pageDomainTextReference) {
-            super(context, uri, true, 0); // baseDomain.
+            super(context, uri, true, 1); // subdomain.domain.tld.
             this.pageDomainViewWeakReference = new WeakReference<>(pageDomainView);
             this.pageDomainTextReference = pageDomainTextReference;
         }
 
         @Override
         protected void onPostExecute(final String baseDomain) {
             super.onPostExecute(baseDomain);