Bug 1531008: Replace makeURI with Services.io.newURI r=johannh
authorPavithra <pavithra.e@hotmail.com>
Thu, 28 Feb 2019 11:32:18 +0000
changeset 519648 184d162629aa8272fa2181c85c62dd9f2eeee1f8
parent 519647 04fb2d9beeaca0c1a3d69b69787c8878995f97ed
child 519649 b3a4dde40f1543ca4b4579485cceadd9aefd7eca
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjohannh
bugs1531008
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1531008: Replace makeURI with Services.io.newURI r=johannh Replaced makeURI with Services.io.newURI Differential Revision: https://phabricator.services.mozilla.com/D21404
browser/base/content/browser-captivePortal.js
--- a/browser/base/content/browser-captivePortal.js
+++ b/browser/base/content/browser-captivePortal.js
@@ -256,17 +256,17 @@ var CaptivePortalWatcher = {
           userContextId: gBrowser.contentPrincipal.userContextId,
         }),
       });
       this._captivePortalTab = Cu.getWeakReference(tab);
     }
 
     gBrowser.selectedTab = tab;
 
-    let canonicalURI = makeURI(this.canonicalURL);
+    let canonicalURI = Services.io.newURI(this.canonicalURL);
 
     // When we are no longer captive, close the tab if it's at the canonical URL.
     let tabCloser = () => {
       Services.obs.removeObserver(tabCloser, "captive-portal-login-abort");
       Services.obs.removeObserver(tabCloser, "captive-portal-login-success");
       if (!tab || tab.closing || !tab.parentNode || !tab.linkedBrowser ||
           !tab.linkedBrowser.currentURI.equalsExceptRef(canonicalURI)) {
         return;