Bug 1523312 - do not export msgpack, as it has no callers out side of libxul r=dmajor
authorRobert Helmer <rhelmer@mozilla.com>
Wed, 27 Feb 2019 19:33:54 +0000
changeset 519380 183e091dee1483a230eb8471aff56b4d573bc0ca
parent 519379 a14f91947d1feb707b28bcdd240134885df45177
child 519381 8ec03a6f1ca514d39dbb71bbf887edb0681b3832
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmajor
bugs1523312
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1523312 - do not export msgpack, as it has no callers out side of libxul r=dmajor Includes a drive-by fix for two unused `DEFINES`. Differential Revision: https://phabricator.services.mozilla.com/D17859
third_party/msgpack/moz.build
third_party/prio/moz.build
--- a/third_party/msgpack/moz.build
+++ b/third_party/msgpack/moz.build
@@ -1,15 +1,15 @@
 # -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-DEFINES['MSGPACK_BUILD_LIBRARY'] = True
+DEFINES['MSGPACK_DLLEXPORT'] = ''
 
 LOCAL_INCLUDES += [
     'include',
 ]
 
 EXPORTS += [
     'include/msgpack.h',
     'include/msgpack/util.h',
--- a/third_party/prio/moz.build
+++ b/third_party/prio/moz.build
@@ -1,15 +1,13 @@
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-DEFINES['PRIO_BUILD_LIBRARY'] = True
-
 LOCAL_INCLUDES += [
     '/security/nss/lib/freebl/mpi',
     '/third_party/msgpack/include',
     'include',
 ]
 
 EXPORTS += [
     'include/mprio.h',