Bug 1534875 - Remove SearchWidgetConfigurationActivity from search's appwidget-provider; r=VladBaicu
authorPetru Lingurar <petru.lingurar@softvision.ro>
Thu, 14 Mar 2019 17:13:32 +0000
changeset 521949 182f8f4a800c
parent 521948 24870321bdeb
child 521950 a09b3ceb8f72
push id10870
push usernbeleuzu@mozilla.com
push dateFri, 15 Mar 2019 20:00:07 +0000
treeherdermozilla-beta@c594aee5b7a4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersVladBaicu
bugs1534875
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1534875 - Remove SearchWidgetConfigurationActivity from search's appwidget-provider; r=VladBaicu This was a leftover from an initial implementation which needed to track certain events related to the user adding the search widget. Otherwise it is not needed as we don't actually expose any widget settings to be configured by the user before adding it. Turns out this Activity would actually mess with our PendingIntents which would not fire for when tapping search widget's elements. Differential Revision: https://phabricator.services.mozilla.com/D23543
mobile/android/app/src/main/res/xml/search_widget_info.xml
--- a/mobile/android/app/src/main/res/xml/search_widget_info.xml
+++ b/mobile/android/app/src/main/res/xml/search_widget_info.xml
@@ -1,18 +1,16 @@
 <?xml version="1.0" encoding="utf-8"?>
 
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <appwidget-provider xmlns:android="http://schemas.android.com/apk/res/android"
-    android:configure="org.mozilla.gecko.search.SearchWidgetConfigurationActivity"
     android:initialLayout="@layout/widget_search_default_col_layout"
     android:minWidth="360dp"
     android:minHeight="40dp"
     android:minResizeWidth="64dp"
     android:minResizeHeight="40dp"
     android:previewImage="@drawable/search_widget_preview"
     android:resizeMode="horizontal">
 
 </appwidget-provider>
-