Bug 1528266 [wpt PR 15413] - Simplify test_driver_internal to not use prototype + Object.create, a=testonly
authorPhilip Jägenstedt <philip@foolip.org>
Tue, 05 Mar 2019 12:17:38 +0000
changeset 522187 18139e69e3c561aaef01da0d039fb19cdd4fdc75
parent 522186 e5f7bd9d93a4110b8d1890601ba6d70029ad4ef5
child 522188 da708ab85cc67a562f57700543722de285dc8d72
push id10871
push usercbrindusan@mozilla.com
push dateMon, 18 Mar 2019 15:49:32 +0000
treeherdermozilla-beta@018abdd16060 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1528266, 15413, 11173
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1528266 [wpt PR 15413] - Simplify test_driver_internal to not use prototype + Object.create, a=testonly Automatic update from web-platform-tests Simplify test_driver_internal to not use prototype + Object.create (#15413) Context: https://github.com/web-platform-tests/wpt/pull/11173/files#r236038149 -- wpt-commits: 83e8b970efc66feed5fde392d80209ea6540a283 wpt-pr: 15413
testing/web-platform/tests/resources/testdriver.js
--- a/testing/web-platform/tests/resources/testdriver.js
+++ b/testing/web-platform/tests/resources/testdriver.js
@@ -192,17 +192,17 @@
          * @returns {Promise} fufiled after the actions are performed, or rejected in
          *                    the cases the WebDriver command errors
          */
         action_sequence: function(actions) {
             return window.test_driver_internal.action_sequence(actions);
         }
     };
 
-    var manual = {
+    window.test_driver_internal = {
         /**
          * This flag should be set to `true` by any code which implements the
          * internal methods defined below for automation purposes. Doing so
          * allows the library to signal failure immediately when an automated
          * implementation of one of the methods is not available.
          */
         in_automation: false,
 
@@ -278,12 +278,9 @@
          *
          * @returns {Promise} fufilled after actions are sent, rejected if any actions
          *                    fail
          */
         action_sequence: function(actions) {
             return Promise.reject(new Error("unimplemented"));
         }
     };
-
-    window.test_driver_internal = Object.create(manual);
-
 })();