Bug 1218257 - Use a different property other than word-spacing for a test. r=me
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sun, 03 Mar 2019 03:31:55 +0100
changeset 520051 16ebe5e32775afa93eec29766332c8e1e04e62c6
parent 520050 0456bc2c98e2749e932d5d1b20e526a96797e4ca
child 520052 4f78b47f52b2f138e472b6fd54b83b4b8031a967
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1218257
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1218257 - Use a different property other than word-spacing for a test. r=me word-spacing is still using the old Gecko computed style storage, which means that it has a little bit of precision loss that I just fixed for stroke-width.
testing/web-platform/meta/svg/painting/parsing/stroke-width-computed.svg.ini
testing/web-platform/tests/svg/painting/parsing/stroke-width-computed.svg
deleted file mode 100644
--- a/testing/web-platform/meta/svg/painting/parsing/stroke-width-computed.svg.ini
+++ /dev/null
@@ -1,7 +0,0 @@
-[stroke-width-computed.svg]
-  [stroke-width computes mm lengths]
-    expected: FAIL
-    bug: Precision difference with non-Servo serialization.
-  [stroke-width computes Q lengths]
-    expected: FAIL
-    bug: Precision difference with non-Servo serialization.
--- a/testing/web-platform/tests/svg/painting/parsing/stroke-width-computed.svg
+++ b/testing/web-platform/tests/svg/painting/parsing/stroke-width-computed.svg
@@ -45,16 +45,16 @@ const lengthUnits = [
 
 for (let lengthUnit of lengthUnits) {
   const length = '987' + lengthUnit;
   test(() => {
     const target = document.getElementById('target');
     target.style.strokeWidth = length;
 
     const ref = document.getElementById('ref');
-    ref.style.wordSpacing = length;
+    ref.style.textIndent = length;
 
-    assert_equals(getComputedStyle(target).strokeWidth, getComputedStyle(ref).wordSpacing);
+    assert_equals(getComputedStyle(target).strokeWidth, getComputedStyle(ref).textIndent);
   }, 'stroke-width computes ' + lengthUnit + ' lengths');
 }
 
   ]]></script>
 </svg>