Bug 919490 - Learn More link in Sync discovery pane shouldn't open a tab in popups. r=gavin
authorDão Gottwald <dao@mozilla.com>
Thu, 26 Sep 2013 11:16:46 +0200
changeset 162598 153254a69c0007f36df73777d06bc257809110ba
parent 162597 160ec7af5cb95369a0d5338ae035999f89563ee6
child 162599 55bd39f913d18b52191eefa67d9b4dc14e808007
push id3066
push userakeybl@mozilla.com
push dateMon, 09 Dec 2013 19:58:46 +0000
treeherdermozilla-beta@a31a0dce83aa [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgavin
bugs919490
milestone27.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 919490 - Learn More link in Sync discovery pane shouldn't open a tab in popups. r=gavin
browser/base/content/urlbarBindings.xml
--- a/browser/base/content/urlbarBindings.xml
+++ b/browser/base/content/urlbarBindings.xml
@@ -2127,18 +2127,17 @@
         <body><![CDATA[
           this._viewsLeft = 0;
           this.hidden = true;
         ]]></body>
       </method>
       <method name="onLinkClick">
         <body><![CDATA[
           // Open a new selected tab and close the current panel.
-          gBrowser.loadOneTab(this._promolink.getAttribute("href"),
-                              { inBackground: false });
+          openUILinkIn(this._promolink.getAttribute("href"), "tab");
           this._panel.hidePopup();
         ]]></body>
       </method>
       <method name="handleEvent">
         <parameter name="event"/>
         <body><![CDATA[
           if (event.type != "popupshowing" || event.target != this._panel)
             return;