Bug 1473837 - AddonInstall should flush the jar cache for the temporary xpi file before trying to remove it. r=kmag a=RyanVM
authorLuca Greco <lgreco@mozilla.com>
Fri, 16 Aug 2019 21:49:33 +0000
changeset 542058 14b258057e3438522d89cae57b399d89af4d8d01
parent 542057 a7f4215a7edaab8ab3341177feae92b0b1393b08
child 542059 acc14f127be23d0c8f8eab04d396f3473c9f8690
push id11834
push useraiakab@mozilla.com
push dateThu, 22 Aug 2019 16:18:09 +0000
treeherdermozilla-beta@ccdf246fedb2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskmag, RyanVM
bugs1473837
milestone69.0
Bug 1473837 - AddonInstall should flush the jar cache for the temporary xpi file before trying to remove it. r=kmag a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D41360
toolkit/mozapps/extensions/internal/XPIInstall.jsm
--- a/toolkit/mozapps/extensions/internal/XPIInstall.jsm
+++ b/toolkit/mozapps/extensions/internal/XPIInstall.jsm
@@ -1473,16 +1473,17 @@ class AddonInstall {
       return;
     }
 
     try {
       this.logger.debug(
         `removeTemporaryFile: ${this.sourceURI.spec} removing temp file ` +
           this.file.path
       );
+      flushJarCache(this.file);
       this.file.remove(true);
       this.ownsTempFile = false;
     } catch (e) {
       this.logger.warn(
         `Failed to remove temporary file ${this.file.path} for addon ` +
           this.sourceURI.spec,
         e
       );