Bug 1550364 part 5. Get rid of nsIUDPSocketChild. r=baku
authorBoris Zbarsky <bzbarsky@mit.edu>
Thu, 09 May 2019 06:55:06 +0000
changeset 532109 1456c2b5efb899d210fb91f2ebedfcad7c094bea
parent 532108 dfbb67a692f4c1a257edd0b441a84b8c01a8e9c7
child 532110 91754861e8d845ea6d84ae52b4ebad339fd89d96
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbaku
bugs1550364
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1550364 part 5. Get rid of nsIUDPSocketChild. r=baku Differential Revision: https://phabricator.services.mozilla.com/D30448
dom/network/UDPSocketChild.cpp
dom/network/UDPSocketChild.h
dom/network/interfaces/nsIUDPSocketChild.idl
--- a/dom/network/UDPSocketChild.cpp
+++ b/dom/network/UDPSocketChild.cpp
@@ -15,17 +15,17 @@
 #include "mozilla/ipc/BackgroundUtils.h"
 #include "mozilla/ipc/PBackgroundSharedTypes.h"
 
 using mozilla::net::gNeckoChild;
 
 namespace mozilla {
 namespace dom {
 
-NS_IMPL_ISUPPORTS(UDPSocketChildBase, nsIUDPSocketChild)
+NS_IMPL_ISUPPORTS(UDPSocketChildBase, nsISupports)
 
 UDPSocketChildBase::UDPSocketChildBase() : mIPCOpen(false) {}
 
 UDPSocketChildBase::~UDPSocketChildBase() {}
 
 void UDPSocketChildBase::ReleaseIPDLReference() {
   MOZ_ASSERT(mIPCOpen);
   mIPCOpen = false;
--- a/dom/network/UDPSocketChild.h
+++ b/dom/network/UDPSocketChild.h
@@ -17,34 +17,33 @@
     0xb47e5a0f, 0xd384, 0x48ef, {                    \
       0x88, 0x85, 0x42, 0x59, 0x79, 0x3d, 0x9c, 0xf0 \
     }                                                \
   }
 
 namespace mozilla {
 namespace dom {
 
-class UDPSocketChildBase : public nsIUDPSocketChild {
+class UDPSocketChildBase : public nsISupports {
  public:
   NS_DECL_ISUPPORTS
 
   void AddIPDLReference();
   void ReleaseIPDLReference();
 
  protected:
   UDPSocketChildBase();
   virtual ~UDPSocketChildBase();
   nsCOMPtr<nsIUDPSocketInternal> mSocket;
   bool mIPCOpen;
 };
 
 class UDPSocketChild : public mozilla::net::PUDPSocketChild,
                        public UDPSocketChildBase {
  public:
-  NS_DECL_NSIUDPSOCKETCHILD
   NS_IMETHOD_(MozExternalRefCountType) Release() override;
 
   UDPSocketChild();
   virtual ~UDPSocketChild();
 
   uint16_t LocalPort() const { return mLocalPort; }
   // Local address as UTF-8.
   const nsACString& LocalAddress() const { return mLocalAddress; }
--- a/dom/network/interfaces/nsIUDPSocketChild.idl
+++ b/dom/network/interfaces/nsIUDPSocketChild.idl
@@ -5,21 +5,16 @@
 #include "nsISupports.idl"
 #include "nsINetAddr.idl"
 
 interface nsIUDPSocketInternal;
 interface nsIInputStream;
 interface nsIPrincipal;
 interface nsIEventTarget;
 
-[uuid(1e6ad73b-6c05-4d78-9a88-2d357b88f58b)]
-interface nsIUDPSocketChild : nsISupports
-{
-};
-
 /*
  * Internal interface for callback from chrome process
  */
 [scriptable, uuid(613dd3ad-598b-4da9-ad63-bbda50c20098)]
 interface nsIUDPSocketInternal : nsISupports
 {
   // callback while socket is opened. localPort and localAddress is ready until this time.
   void callListenerOpened();