Bug 1471641 - Enable and fix mozinstall tests on python 3 r=davehunt
authorWilliam Lachance <wlachance@mozilla.com>
Wed, 02 Jan 2019 09:54:44 +0000
changeset 509368 11580728adf0ca32a5bdf0b276385979c535ec0c
parent 509367 17049f612abe7a62b454add8c110e0993f84e5a6
child 509369 e0d35b7a804edaaa29c339e3e1971c410fd6437d
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdavehunt
bugs1471641
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1471641 - Enable and fix mozinstall tests on python 3 r=davehunt Depends on D15540 Differential Revision: https://phabricator.services.mozilla.com/D15541
testing/mozbase/mozinstall/tests/manifest.ini
testing/mozbase/mozinstall/tests/test_install.py
--- a/testing/mozbase/mozinstall/tests/manifest.ini
+++ b/testing/mozbase/mozinstall/tests/manifest.ini
@@ -1,9 +1,8 @@
 [DEFAULT]
 subsuite = mozbase
-skip-if = python == 3
 [test_binary.py]
 skip-if = os == "mac"
 [test_install.py]
 skip-if = os == "mac"  # intermittent
 [test_is_installer.py]
 [test_uninstall.py]
--- a/testing/mozbase/mozinstall/tests/test_install.py
+++ b/testing/mozbase/mozinstall/tests/test_install.py
@@ -68,14 +68,14 @@ def test_install(tmpdir, get_installer):
 
         installdir_zip = mozinstall.install(get_installer('zip'), tmpdir.join('zip').strpath)
         assert installdir_zip == tmpdir.join('zip', 'firefox').strpath
 
     elif mozinfo.isMac:
         installdir = mozinstall.install(get_installer('dmg'), tmpdir.strpath)
         assert installdir == tmpdir.realpath().join('Firefox Stub.app').strpath
 
-        mounted_images = subprocess.check_output(['hdiutil', 'info'])
+        mounted_images = subprocess.check_output(['hdiutil', 'info']).decode('ascii')
         assert get_installer('dmg') not in mounted_images
 
 
 if __name__ == '__main__':
     mozunit.main()