Bug 1373154 (part 2) - Don't call AllocPlatformData() in profiler_get_backtrace(). r=mstange.
☠☠ backed out by cd069d0b934e ☠ ☠
authorNicholas Nethercote <nnethercote@mozilla.com>
Thu, 15 Jun 2017 22:02:08 +1000
changeset 412998 0e89b1564ea466ad1434fefffe446853bb154ec4
parent 412997 48767f3f315f41ff152d4d3c8a9c418c7bb29aec
child 412999 ca4e62117e6ad325756b62de03917d4fb188165d
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange
bugs1373154
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1373154 (part 2) - Don't call AllocPlatformData() in profiler_get_backtrace(). r=mstange. We already have a PlatformData for the thread in its ThreadInfo.
tools/profiler/core/platform.cpp
--- a/tools/profiler/core/platform.cpp
+++ b/tools/profiler/core/platform.cpp
@@ -2828,19 +2828,17 @@ profiler_get_backtrace()
     MOZ_ASSERT(info);
     return nullptr;
   }
 
   Thread::tid_t tid = Thread::GetCurrentId();
 
   ProfileBuffer* buffer = new ProfileBuffer(PROFILER_GET_BACKTRACE_ENTRIES);
 
-  UniquePlatformData platformData = AllocPlatformData(tid);
-
-  TickSample sample(info->RacyInfo(), info->mContext, platformData.get());
+  TickSample sample(info->RacyInfo(), info->mContext, info->GetPlatformData());
 
 #if defined(HAVE_NATIVE_UNWIND)
 #if defined(GP_OS_linux) || defined(GP_OS_android)
   ucontext_t context;
   sample.PopulateContext(&context);
 #else
   sample.PopulateContext();
 #endif