Bug 1514058 - Restore color of selected about:debugging category;r=ntim a=RyanVM
authorJulian Descottes <jdescottes@mozilla.com>
Fri, 14 Dec 2018 11:18:28 +0000
changeset 506255 0e6457cd968ab6e8654001a595d170f0dc5fa37a
parent 506254 3735c6ea013c3fd85ae3db6372c002b05d33929e
child 506256 04d44d6052d17a4e8925b7af536f130250e7fba7
push id10348
push userebalazs@mozilla.com
push dateMon, 17 Dec 2018 10:13:16 +0000
treeherdermozilla-beta@04d44d6052d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersntim, RyanVM
bugs1514058
milestone65.0
Bug 1514058 - Restore color of selected about:debugging category;r=ntim a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D14495
devtools/client/aboutdebugging/aboutdebugging.css
toolkit/themes/shared/in-content/common.inc.css
--- a/devtools/client/aboutdebugging/aboutdebugging.css
+++ b/devtools/client/aboutdebugging/aboutdebugging.css
@@ -21,20 +21,26 @@ button {
 /* Category panels */
 
 #categories {
   display: flex;
   flex-direction: column;
 }
 
 .category {
-  border: 0 solid transparent;
+  align-items: center;
+  /* Override a `background-color` set on all buttons by common.inc.css */
+  background-color: transparent;
   display: flex;
   flex-direction: row;
-  align-items: center;
+}
+
+.category.selected {
+  /* Override a `color: inherit !important` forced on all buttons by common.inc.css */
+  color: var(--in-content-category-text-selected) !important;
 }
 
 .category-name {
   cursor: default;
 }
 
 .app {
   height: 100%;
--- a/toolkit/themes/shared/in-content/common.inc.css
+++ b/toolkit/themes/shared/in-content/common.inc.css
@@ -604,20 +604,16 @@ xul|*.radio-label-box {
   -moz-appearance: none;
   color: var(--in-content-category-text);
   margin-inline-start: 34px;
   padding-inline-end: 10px;
   padding-inline-start: 10px;
   transition: background-color 150ms;
 }
 
-*|*#categories > *|button.category {
-  background-color: transparent;
-}
-
 *|*#categories > *|*.category:hover {
   background-color: var(--in-content-category-background-hover);
   border-radius: 2px;
 }
 
 *|*#categories > *|*.category:hover:active {
   background-color: var(--in-content-category-background-active);
 }